Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fullscreen --no-outer-gaps #373

Closed
jomag opened this issue Aug 11, 2024 · 7 comments
Closed

Implement fullscreen --no-outer-gaps #373

jomag opened this issue Aug 11, 2024 · 7 comments
Labels
good-first-issue Easy to fix issues. Good for newcomers

Comments

@jomag
Copy link

jomag commented Aug 11, 2024

When in (non-native) fullscreen mode, I typically want to disable gaps to maximize screen usage. It would be nice if gaps could be customized for fullscreen, just like they can with monitor patterns.

Related, it would also be nice to optionally treat workspaces with a single window as fullscreen, removing gaps.

@nikitabobko
Copy link
Owner

But why?

If users use gaps for practical purposes to distinguish between windows then they can only use the inner gaps and set outer gaps to zero

If users use gaps for aesthetic purposes then users will use both outer and inner gaps

Related: #54

@jomag
Copy link
Author

jomag commented Aug 11, 2024

Good point. My reason for wanting this functionality is somewhere in between: I want gaps for separation of windows. However, having only inner gaps does not look great IMO.

So for fullscreen or single-window workspaces, I don't want gaps as they add no practical value. In all other cases, I want gaps between windows for practical reasons, and around them for aesthetics.

@nikitabobko
Copy link
Owner

I don't mind if somebody adds a fullscreen --no-outer-gaps flag

It's a minor priority for me, and it's a good-first-issue so PRs are welcome

@nikitabobko nikitabobko added the good-first-issue Easy to fix issues. Good for newcomers label Aug 11, 2024
@nikitabobko nikitabobko changed the title Disable or set custom gaps in fullscreen mode Implement fullscreen --no-outer-gaps Aug 11, 2024
@nikitabobko
Copy link
Owner

Related, it would also be nice to optionally treat workspaces with a single window as fullscreen, removing gaps.

It will be fixed semi-automatically with #278 Please see #60 (comment)

@nikitabobko
Copy link
Owner

nikitabobko commented Aug 14, 2024

Alternative name: fullscreen --ignore-outer-gaps

@vrumger
Copy link
Contributor

vrumger commented Sep 1, 2024

fixed in #472 (7d90410) 🎉

@nikitabobko
Copy link
Owner

Released in 0.15.0-Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Easy to fix issues. Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants