From 791f77b83006895438f2de53c86787c0f15b8a31 Mon Sep 17 00:00:00 2001 From: elasticsearchmachine Date: Thu, 20 Feb 2025 20:11:04 +0000 Subject: [PATCH] [CI] Auto commit changes from spotless --- .../compute/aggregation/ValuesBytesRefAggregator.java | 6 ++++-- .../compute/aggregation/ValuesDoubleAggregator.java | 6 ++++-- .../compute/aggregation/ValuesFloatAggregator.java | 6 ++++-- .../compute/aggregation/ValuesIntAggregator.java | 6 ++++-- .../compute/aggregation/ValuesLongAggregator.java | 6 ++++-- 5 files changed, 20 insertions(+), 10 deletions(-) diff --git a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregator.java b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregator.java index e61d70403d71b..1431911686ec7 100644 --- a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregator.java +++ b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregator.java @@ -179,8 +179,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { } /* - * Total the sign selected groups and turn them into a running count. - * Negative counts are still unselected. + * Total the selected groups and turn them into a running count. + * Unselected groups will still have negative counts. */ int total = 0; for (int s = 0; s < selected.getPositionCount(); s++) { @@ -195,6 +195,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { * Build a list of ids to insert in order *and* convert the running * count in selectedCounts[group] into the end index in ids for each * group. + * Here we use the negative counts to signal that a group hasn't been + * selected and the id containing values for that group is ignored. */ idsSize = RamUsageEstimator.alignObjectSize(RamUsageEstimator.NUM_BYTES_ARRAY_HEADER + total * Integer.BYTES); blockFactory.adjustBreaker(idsSize); diff --git a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesDoubleAggregator.java b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesDoubleAggregator.java index b05aa2f2053c9..906630875f012 100644 --- a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesDoubleAggregator.java +++ b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesDoubleAggregator.java @@ -158,8 +158,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { } /* - * Total the sign selected groups and turn them into a running count. - * Negative counts are still unselected. + * Total the selected groups and turn them into a running count. + * Unselected groups will still have negative counts. */ int total = 0; for (int s = 0; s < selected.getPositionCount(); s++) { @@ -174,6 +174,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { * Build a list of ids to insert in order *and* convert the running * count in selectedCounts[group] into the end index in ids for each * group. + * Here we use the negative counts to signal that a group hasn't been + * selected and the id containing values for that group is ignored. */ idsSize = RamUsageEstimator.alignObjectSize(RamUsageEstimator.NUM_BYTES_ARRAY_HEADER + total * Integer.BYTES); blockFactory.adjustBreaker(idsSize); diff --git a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesFloatAggregator.java b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesFloatAggregator.java index 837c96e045b62..bd4c867916204 100644 --- a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesFloatAggregator.java +++ b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesFloatAggregator.java @@ -164,8 +164,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { } /* - * Total the sign selected groups and turn them into a running count. - * Negative counts are still unselected. + * Total the selected groups and turn them into a running count. + * Unselected groups will still have negative counts. */ int total = 0; for (int s = 0; s < selected.getPositionCount(); s++) { @@ -180,6 +180,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { * Build a list of ids to insert in order *and* convert the running * count in selectedCounts[group] into the end index in ids for each * group. + * Here we use the negative counts to signal that a group hasn't been + * selected and the id containing values for that group is ignored. */ idsSize = RamUsageEstimator.alignObjectSize(RamUsageEstimator.NUM_BYTES_ARRAY_HEADER + total * Integer.BYTES); blockFactory.adjustBreaker(idsSize); diff --git a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesIntAggregator.java b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesIntAggregator.java index d776d686ea156..210f91ac2b261 100644 --- a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesIntAggregator.java +++ b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesIntAggregator.java @@ -164,8 +164,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { } /* - * Total the sign selected groups and turn them into a running count. - * Negative counts are still unselected. + * Total the selected groups and turn them into a running count. + * Unselected groups will still have negative counts. */ int total = 0; for (int s = 0; s < selected.getPositionCount(); s++) { @@ -180,6 +180,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { * Build a list of ids to insert in order *and* convert the running * count in selectedCounts[group] into the end index in ids for each * group. + * Here we use the negative counts to signal that a group hasn't been + * selected and the id containing values for that group is ignored. */ idsSize = RamUsageEstimator.alignObjectSize(RamUsageEstimator.NUM_BYTES_ARRAY_HEADER + total * Integer.BYTES); blockFactory.adjustBreaker(idsSize); diff --git a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesLongAggregator.java b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesLongAggregator.java index 89aec3993556e..2e6147ad8a92e 100644 --- a/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesLongAggregator.java +++ b/x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesLongAggregator.java @@ -158,8 +158,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { } /* - * Total the sign selected groups and turn them into a running count. - * Negative counts are still unselected. + * Total the selected groups and turn them into a running count. + * Unselected groups will still have negative counts. */ int total = 0; for (int s = 0; s < selected.getPositionCount(); s++) { @@ -174,6 +174,8 @@ Block toBlock(BlockFactory blockFactory, IntVector selected) { * Build a list of ids to insert in order *and* convert the running * count in selectedCounts[group] into the end index in ids for each * group. + * Here we use the negative counts to signal that a group hasn't been + * selected and the id containing values for that group is ignored. */ idsSize = RamUsageEstimator.alignObjectSize(RamUsageEstimator.NUM_BYTES_ARRAY_HEADER + total * Integer.BYTES); blockFactory.adjustBreaker(idsSize);