From 4039c41c997077fb11616786ea06e6f53549ee6c Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Wed, 3 Jan 2024 16:40:33 -0500 Subject: [PATCH] Different comment --- .../java/org/elasticsearch/index/mapper/MapperTestCase.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/framework/src/main/java/org/elasticsearch/index/mapper/MapperTestCase.java b/test/framework/src/main/java/org/elasticsearch/index/mapper/MapperTestCase.java index cab0d4e7dc02a..5bbd3736bc7b6 100644 --- a/test/framework/src/main/java/org/elasticsearch/index/mapper/MapperTestCase.java +++ b/test/framework/src/main/java/org/elasticsearch/index/mapper/MapperTestCase.java @@ -1260,8 +1260,8 @@ protected boolean supportsColumnAtATimeReader(MapperService mapper, MappedFieldT } private void testBlockLoader(boolean syntheticSource, boolean columnReader) throws IOException { + // TODO if we're not using synthetic source use a different sort of example. Or something. SyntheticSourceExample example = syntheticSourceSupport(false).example(5); - // TODO when synthetic _source is disabled disable doc values. XContentBuilder mapping = syntheticSource ? syntheticSourceFieldMapping(example.mapping) : fieldMapping(example.mapping); MapperService mapper = createMapperService(mapping); testBlockLoader(columnReader, example, mapper, "field");