Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.net 5 #45

Open
nicolgit opened this issue Mar 27, 2021 · 4 comments
Open

.net 5 #45

nicolgit opened this issue Mar 27, 2021 · 4 comments
Labels
postponed postponed question Further information is requested

Comments

@nicolgit
Copy link
Owner

just found this

https://azure.microsoft.com/en-us/updates/general-availability-azure-functions-supports-net-5-in-production/

@fume @liguori do we want to upgrade to .net 5 all?

@nicolgit nicolgit added the question Further information is requested label Mar 27, 2021
@liguori
Copy link
Collaborator

liguori commented Apr 10, 2021

@nicolgit I was playing a little bit with the isolated model (.NET 5) but at the moment I would avoid to use it given the little support of the development tools:
Azure/azure-functions-dotnet-worker#331
https://stackoverflow.com/questions/67013422/upgrading-azure-functions-to-5-0-system-uriformatexception

We can plan to reserve this conversion at the end of the other tasks. In the meantime we can bring back to .NET 3.1 the 'whoiswho\api\api.csproj' in order to have a consistent deployment of the same version of all the Function Apps.

@liguori liguori removed their assignment Apr 10, 2021
@nicolgit
Copy link
Owner Author

Make sense to wait for a while before migrating all to .Net 5.

Now API looks working, I'd keep them in .Net 5 flavour as long as we incur in some blocking issue...

@liguori
Copy link
Collaborator

liguori commented Apr 12, 2021

I don't know if it work seamlessy with ARM template and GitHub actions that we already have for the Function App with .NET 3.1
@nicolgit look at this PR:
#49

I have already prepared / reused the existing code for 3.1 applied to the "WhoIsWho.Portal.API"

I would keep everything at 3.1 and then update

@nicolgit nicolgit added the postponed postponed label Apr 15, 2021
@nicolgit
Copy link
Owner Author

let's remain in 3.1 for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed postponed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants