Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Installation instructions", and especially dependencies, needed #3

Closed
adeleplunkett opened this issue Jan 30, 2023 · 6 comments
Closed

Comments

@adeleplunkett
Copy link

For the JOSS review, openjournals/joss-reviews#4942, please include clear installation instructions. From the review checklist:

Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.

This will help the user greatly.

@jeffjennings
Copy link

jeffjennings commented Feb 10, 2023

I agree; for the installation instructions, you could consider moving steps 1 - 4 in the docs tutorial 1 to the docs install.

For the dependencies, a setup.py in the top level of the codebase should list all dependencies in the scripts (numpy, etc.).

See #13 for further discussion on both points.

openjournals/joss-reviews#4942

@nicokurtovic
Copy link
Owner

Thank you very much for your suggestions.

One of the main ideas of the package is to be as simple to use as possible. In its current version, SIMIO does not need any additional dependency to be installed, neither internal installs of the package. The package is ready to use after being downloaded, as long as a template and a project have been included. I moved the first and second step of tutorial 1 to the installation.

Since the package is executed from the CASA terminal, the python libraries such as numpy or scipy are already included in the python of CASA, and thus the user does not need to install them independently in their own python. I included additional clarification that CASA needs to be installed in order to use SIMIO.

@jeffjennings
Copy link

jeffjennings commented Nov 30, 2023

I see, thank you for considering this, and for adding the clarification. I think it would still be nice to have the package be standalone, but since the current functionality is what's detailed in the paper, of course that's up to you. But could you be a bit more explicit in the paper that SIMIO is a set of programs designed to be run in CASA?

I'd suggest something like changing line 34 in the paper from "SIMIO-continuum is a python-based package for CASA" to "SIMIO-continuum is a set of Python modules designed to be executed within a CASA Python environment".

@adeleplunkett
Copy link
Author

I agree with @jeffjennings suggestion to modify the text slightly to specify this.

I think that the https://simio-continuum.readthedocs.io/index.html#document-content/simio_installation section is good for installation. I see that there is a file called requirements.txt. This would be a list of dependencies that should be outlined, right?

@nicokurtovic
Copy link
Owner

Hi Adele,

The list of dependencies in docs/requirements.txt only applies for the webpage in redthedocs and the compilation of the documentation pdf. The reason this list is so long is because I had to test many things to fix the problem with the rendering of the equations.

Other than that, the only requirement for SIMIO-continuum should be CASA v5.X or v6.X, as described in the installation instructions.

@jeffjennings
Copy link

I see, thank you for considering this, and for adding the clarification. I think it would still be nice to have the package be standalone, but since the current functionality is what's detailed in the paper, of course that's up to you. But could you be a bit more explicit in the paper that SIMIO is a set of programs designed to be run in CASA?

I'd suggest something like changing line 34 in the paper from "SIMIO-continuum is a python-based package for CASA" to "SIMIO-continuum is a set of Python modules designed to be executed within a CASA Python environment".

Thanks for making this change to the wording in the paper. I'm happy for this issue to be closed when Adele is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants