Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] .github: Add pull request template #719

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

amstewart
Copy link
Contributor

Add a Github PR template to help contributors write high-quality PRs correctly the first time.

Testing

I don't know how to test this. Opening a new PR against my dev branch doesn't prompt with the template. But this is basically just a copy of what we have been using in the nilrt-snac repo.

Add a Github PR template to help contributors write high-quality PRs
correctly the first time.

Signed-off-by: Alex Stewart <[email protected]>
@amstewart amstewart requested review from chaitu236 and a team August 19, 2024 22:12
Copy link
Contributor

@chaitu236 chaitu236 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to under docs directory? Or is there a reason we'd want to keep it hidden in .github directory?

@amstewart
Copy link
Contributor Author

Can we move this to under docs directory? Or is there a reason we'd want to keep it hidden in .github directory?

.github/ was just my preference. I think it makes more clear that the PR template is only relevant to the github build infrastructure. I like the design of putting all github content under .github, all gitlab content under .gitlab, et c.

@chaitu236 chaitu236 merged commit 689d16e into ni:nilrt/master/next Aug 20, 2024
@amstewart amstewart deleted the dev/next/pr-template branch August 20, 2024 14:23
@chaitu236
Copy link
Contributor

Cherry-picked to nilrt/master/kirkstone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants