Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Header scss #711

Closed
chrimesdev opened this issue Mar 4, 2021 · 0 comments · Fixed by #779
Closed

Refactor the Header scss #711

chrimesdev opened this issue Mar 4, 2021 · 0 comments · Fixed by #779
Assignees
@magicaljellybeans
Labels
good first issue Good for newcomers header sass / css

Comments

@chrimesdev
Copy link
Member

chrimesdev commented Mar 4, 2021 •
edited
Loading

Description

The Header component scss is quite complicated and difficult to maintain. It could probably be simplified and reduced in size by quite a bit. There also seem to be a few unused, duplicate styles and some code comments do not match up to code.

Following our Scss coding standards refactor the Header component so its easier to maintain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magicaljellybeans magicaljellybeans

Labels
good first issue Good for newcomers header sass / css
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor header scss nhsuk/nhsuk-frontend
2 participants
@chrimesdev @magicaljellybeans