Details: addDetailsPolyfill isn't designed to be called multiple times, causes issues for single page apps with multiple details components

[andyfrost01]

Bug Report

What is the issue?

We are using angularjs and therefore have a single page app and due to the started flag in the addDetailsPolyfill() we are unable to call this multiple times when another details element has been dynamically added to the DOM.

Ideally we would like the ability to;

• Call it again on the whole page
• Call it again on a particular root element, to scan a sub section of the page

What steps are required to reproduce the issue?

To recreate the issue;
Run the addDetailsPolyfill function and then add another details element to the DOM and then try rerunning the addDetailsPolyfill, the if(NHSUK.details.started) will catch and return meaning that the new details element doesn't get the required new attributes in order to work.

What was the environment where this issue occurred?

• Device: NA
• Operating System: Windows 10
• Browser: IE
• Browser version: Any
• NHS.UK frontend package version: 1.0
• Node version: 10.14.2
• npm version: 6.4.1

[chrimesdev]

Hi @andyfrost01,

Thanks for raising this issue...

Unfortunately, the core frontend library team probably won't have time to look at this issue in the near future. Mainly due to resourcing (summer holidays, other programme commitments etc), along with other frontend library backlog issues and the fact we've not really done any angularjs (or any JavaScript framework) single page applications within the team.

Hopefully, someone from the community will be able to pick it up. Have you attempted a fix? This could be something to contribute back to the system.

[chrimesdev]

Hi @andyfrost01,

Did you have much luck at attempting to fix this issue?

[andyfrost01]

Not currently, as we are currently only using one instance of this component.

[chrimesdev]

This might be potentially fixed by the work being done on #408 by @tomdoughty

[chrimesdev]

This was released in 3.0.0