From e0eb40dd347586ceaf10195b29bc3f04effd842b Mon Sep 17 00:00:00 2001 From: Daniel Edgar Date: Thu, 14 Jul 2022 07:55:04 -0700 Subject: [PATCH 1/5] address 2852 - missing chart values --- docs/content/installation/installation-with-helm.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/content/installation/installation-with-helm.md b/docs/content/installation/installation-with-helm.md index 20f4de59a6..45c9307fe2 100644 --- a/docs/content/installation/installation-with-helm.md +++ b/docs/content/installation/installation-with-helm.md @@ -230,6 +230,8 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont |``controller.readyStatus.enable`` | Enables the readiness endpoint `"/nginx-ready"`. The endpoint returns a success code when NGINX has loaded all the config after the startup. This also configures a readiness probe for the Ingress Controller pods that uses the readiness endpoint. | true | |``controller.readyStatus.port`` | The HTTP port for the readiness endpoint. | 8081 | |``controller.enableLatencyMetrics`` | Enable collection of latency metrics for upstreams. Requires ``prometheus.create``. | false | +``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 +``controller.strategy`` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} |``rbac.create`` | Configures RBAC. | true | |``prometheus.create`` | Expose NGINX or NGINX Plus metrics in the Prometheus format. | false | |``prometheus.port`` | Configures the port to scrape the metrics. | 9113 | From d8838c054bdee42ac421cd954202afd3c2f21cab Mon Sep 17 00:00:00 2001 From: Daniel Edgar Date: Thu, 14 Jul 2022 07:59:38 -0700 Subject: [PATCH 2/5] add table formatting --- docs/content/installation/installation-with-helm.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/content/installation/installation-with-helm.md b/docs/content/installation/installation-with-helm.md index 45c9307fe2..8c281bb20a 100644 --- a/docs/content/installation/installation-with-helm.md +++ b/docs/content/installation/installation-with-helm.md @@ -230,8 +230,8 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont |``controller.readyStatus.enable`` | Enables the readiness endpoint `"/nginx-ready"`. The endpoint returns a success code when NGINX has loaded all the config after the startup. This also configures a readiness probe for the Ingress Controller pods that uses the readiness endpoint. | true | |``controller.readyStatus.port`` | The HTTP port for the readiness endpoint. | 8081 | |``controller.enableLatencyMetrics`` | Enable collection of latency metrics for upstreams. Requires ``prometheus.create``. | false | -``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 -``controller.strategy`` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} +``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 | +``controller.strategy`` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} | |``rbac.create`` | Configures RBAC. | true | |``prometheus.create`` | Expose NGINX or NGINX Plus metrics in the Prometheus format. | false | |``prometheus.port`` | Configures the port to scrape the metrics. | 9113 | From ac1a147efc046434f42d419d0d10c42c3bc2771a Mon Sep 17 00:00:00 2001 From: Daniel Edgar Date: Thu, 14 Jul 2022 14:01:13 -0700 Subject: [PATCH 3/5] review request: add missing pipes --- docs/content/installation/installation-with-helm.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/content/installation/installation-with-helm.md b/docs/content/installation/installation-with-helm.md index 8c281bb20a..1b943fc355 100644 --- a/docs/content/installation/installation-with-helm.md +++ b/docs/content/installation/installation-with-helm.md @@ -230,8 +230,8 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont |``controller.readyStatus.enable`` | Enables the readiness endpoint `"/nginx-ready"`. The endpoint returns a success code when NGINX has loaded all the config after the startup. This also configures a readiness probe for the Ingress Controller pods that uses the readiness endpoint. | true | |``controller.readyStatus.port`` | The HTTP port for the readiness endpoint. | 8081 | |``controller.enableLatencyMetrics`` | Enable collection of latency metrics for upstreams. Requires ``prometheus.create``. | false | -``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 | -``controller.strategy`` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} | +|``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 | +|``controller.strategy`` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} | |``rbac.create`` | Configures RBAC. | true | |``prometheus.create`` | Expose NGINX or NGINX Plus metrics in the Prometheus format. | false | |``prometheus.port`` | Configures the port to scrape the metrics. | 9113 | From ec4d602bd9676b0a08abae542afabf93ea0a0114 Mon Sep 17 00:00:00 2001 From: Daniel Edgar Date: Wed, 20 Jul 2022 13:12:19 -0700 Subject: [PATCH 4/5] Update docs/content/installation/installation-with-helm.md Co-authored-by: Jodie Putrino --- docs/content/installation/installation-with-helm.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/installation/installation-with-helm.md b/docs/content/installation/installation-with-helm.md index 1b943fc355..5701523d05 100644 --- a/docs/content/installation/installation-with-helm.md +++ b/docs/content/installation/installation-with-helm.md @@ -230,7 +230,7 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont |``controller.readyStatus.enable`` | Enables the readiness endpoint `"/nginx-ready"`. The endpoint returns a success code when NGINX has loaded all the config after the startup. This also configures a readiness probe for the Ingress Controller pods that uses the readiness endpoint. | true | |``controller.readyStatus.port`` | The HTTP port for the readiness endpoint. | 8081 | |``controller.enableLatencyMetrics`` | Enable collection of latency metrics for upstreams. Requires ``prometheus.create``. | false | -|``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 | +|``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready, without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 | |``controller.strategy`` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} | |``rbac.create`` | Configures RBAC. | true | |``prometheus.create`` | Expose NGINX or NGINX Plus metrics in the Prometheus format. | false | From 3601362c6981b8bf25d23955125465896139f602 Mon Sep 17 00:00:00 2001 From: Daniel Edgar Date: Wed, 20 Jul 2022 13:12:32 -0700 Subject: [PATCH 5/5] Update docs/content/installation/installation-with-helm.md Co-authored-by: Jodie Putrino --- docs/content/installation/installation-with-helm.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/installation/installation-with-helm.md b/docs/content/installation/installation-with-helm.md index 5701523d05..46faa70b38 100644 --- a/docs/content/installation/installation-with-helm.md +++ b/docs/content/installation/installation-with-helm.md @@ -231,7 +231,7 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont |``controller.readyStatus.port`` | The HTTP port for the readiness endpoint. | 8081 | |``controller.enableLatencyMetrics`` | Enable collection of latency metrics for upstreams. Requires ``prometheus.create``. | false | |``controller.minReadySeconds`` | Specifies the minimum number of seconds for which a newly created Pod should be ready, without any of its containers crashing, for it to be considered available. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) | 0 | -|``controller.strategy`` | Specifies the strategy used to replace old Pods by new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} | +|``controller.strategy`` | Specifies the strategy used to replace old Pods with new ones. [docs](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) | {} | |``rbac.create`` | Configures RBAC. | true | |``prometheus.create`` | Expose NGINX or NGINX Plus metrics in the Prometheus format. | false | |``prometheus.port`` | Configures the port to scrape the metrics. | 9113 |