update dependencies. #105
Merged
update dependencies. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m throws multiple errors now
|
the updated dependencies break on node < 10, that's why travis fails. the node version should be bumped imho, |
|
Thanks. Yeah, Node 8 just left LTS, so I don't think it's worth keeping the backwards compat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i removed transformation matrix and included the code directly in the app,
i can see if #91 and the library linked there can be included easily,
but just discovered that issue, so did not do that yet.
updated istanbul to nyc,
and updated all other dependencies.
one test is a bit different now, because one of the libraries seems to have changed behaviour (output multiple errors instead of only one if i am correct)
my changes work fine in https://github.com/magic/glyphs.