-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generates corrupted svg files. #5
Comments
Wierd indeed. Can you give me the input icons ? |
I tested it with just this one and it still occurs.
|
It looks like the problem comes when the width and height attributes of the SVG icon is not mentionned. I think using the viewport attribute will solve the problem http://www.w3.org/TR/SVG/coords.html#ViewBoxAttribute . I don't know which editor you use, but using Inkscape will ensure you have a width and a height during the time i fix this up. |
A simple fix: A better fix would be nfroidure/svgicons2svgfont#9 I will ship when i'll have enought feedback for this issue nfroidure/svgicons2svgfont#7 |
The svg's are coming from Illustrator, looks like i messed up the export settings. The responsive svg option seems to be the problem here. |
Could you PR the README with a section explaining wich AI options are the best ? |
Using the gulp-iconfont in combination with gulp-iconfont-css and standard configuration outputs corrupted svg files. I'm guessing this also corrupts the eot ttf and woff files.
The only config i used was
fontName
.I see a lot of the following in the svg file (
NaN
andundefined
):The text was updated successfully, but these errors were encountered: