Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No TEMPLATE branch #92

Closed
ewels opened this issue Jul 30, 2020 · 3 comments
Closed

No TEMPLATE branch #92

ewels opened this issue Jul 30, 2020 · 3 comments

Comments

@ewels
Copy link
Member

ewels commented Jul 30, 2020

Hello!

I just pushed a new release of nf-core/tools with the template, but kmermaid failed to sync because it doesn't have a TEMPLATE branch (see nf-core/tools#709 (comment)).

Normally this branch is created when the pipeline repo is "vanilla" with no modifications from the nf-core/tools template. The TEMPLATE branch needs to have a common history with a commit in the main branch which has this state.

It looks like this pipeline wasn't created with nf-core create, so this is a little trickier. The pipeline has to have a manual merge. This process is described in https://nf-co.re/developers/sync#manual-synchronisation

Once you've done this once, all future automated PRs should work fine.

Shout if you have any problems!

Phil

@pranathivemuri
Copy link
Contributor

https://github.com/nf-core/kmermaid/tree/TEMPLATE - Olga and I made a branch now

@ewels ewels reopened this Oct 21, 2020
@ewels
Copy link
Member Author

ewels commented Oct 21, 2020

Ok nice! However I'm afraid that this isn't resolved yet - just creating an orphan TEMPLATE branch is not enough. You need to go on to do the merge into your main code branches (i.e. dev) with the --allow-unrelated-histories as described here: https://nf-co.re/developers/sync#merge-template-into-main-branches

Currently the TEMPLATE branch doesn't share any git history with dev, so no pull-requests or automation can use it:

Once you have done one merge as described in the docs above, they will have shared history and everything will (should) work smoothly from that point onwards.

I hope this makes sense, shout if you have any questions.

Phil

@pranathivemuri
Copy link
Contributor

#110 - Thanks for the feedback, please let us know if this PR will make the sync automatic from next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants