Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "browser not supported" modal only once per session #1350

Closed
corneliusroemer opened this issue Dec 18, 2023 · 3 comments · Fixed by #1366
Closed

Show "browser not supported" modal only once per session #1350

corneliusroemer opened this issue Dec 18, 2023 · 3 comments · Fixed by #1366
Labels
package: nextclade_web prio: low t:feat Type: request of a new feature, functionality, enchancement

Comments

@corneliusroemer
Copy link
Member

Some people may not be able to use Nextclade Web on a supported (and tested) browser, as that list excludes various Chinese browser and Safari, which might be the only browsers available to some users.

On master, we show the "browser not supported" modal whenever the user changes page, even if the user has previously dismissed the modal with "I want to try anyways".

It would be good to show the warning only once per session.

How to reproduce? Set the user agent to an unsupported browser, e.g. Safari.

@corneliusroemer corneliusroemer added t:feat Type: request of a new feature, functionality, enchancement good first issue Good for newcomers help wanted Extra attention is needed needs triage Mark for review and label assignment package: nextclade_web prio: low and removed good first issue Good for newcomers help wanted Extra attention is needed labels Dec 18, 2023
@ivan-aksamentov
Copy link
Member

@corneliusroemer How do you define a session?

@ivan-aksamentov ivan-aksamentov removed the needs triage Mark for review and label assignment label Dec 18, 2023
@corneliusroemer
Copy link
Member Author

Good question, I'd say just store the cookie dismissal in local storage or cookies?

@corneliusroemer
Copy link
Member Author

I've just realized that the banner that shows when you go to "master.clades.nextstrain.org", the one that says "this is a preview version" only shows once when I navigate to the site. I think making the browser warning show with the same dismissal period would be good.

Does this answer the question "how do you define a session" @ivan-aksamentov?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: nextclade_web prio: low t:feat Type: request of a new feature, functionality, enchancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants