Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto calc img size and center #543

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Auto calc img size and center #543

merged 1 commit into from
Jul 20, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 20, 2020

  • Image
  • Fix zoom

Video seems more complicated now that we have plyr as a wrapper 🤔

@skjnldsv skjnldsv added 2. developing Work in progress enhancement New feature or request performances Performances issues and optimisations labels Jul 20, 2020
@skjnldsv skjnldsv self-assigned this Jul 20, 2020
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the enh/image-auto-ratio branch from bed2de7 to 4b32185 Compare July 20, 2020 13:29
@cypress
Copy link

cypress bot commented Jul 20, 2020



Test summary

150 2 0 0


Run details

Project viewer
Status Failed
Commit 75871b4 ℹ️
Started Jul 20, 2020 1:32 PM
Ended Jul 20, 2020 1:34 PM
Duration 02:11 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 78

View run in Cypress Dashboard ➡️


Failures

images.spec.js Failed
1 Open images in viewer > Does not see a loading animation
images-custom-list-loadmore.spec.js Failed
1 Open custom list of images in viewer with pagination > Does not see a loading animation

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@skjnldsv skjnldsv merged commit 689ba4c into master Jul 20, 2020
@skjnldsv skjnldsv deleted the enh/image-auto-ratio branch July 20, 2020 13:36
@skjnldsv
Copy link
Member Author

... Merged too fast! Need zoom! :O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request performances Performances issues and optimisations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant