fix: replace deprecated translation methods #6567

luka-nextcloud · 2024-10-28T15:35:33Z

📝 Summary

Resolves: Replace deprecated translation methods #6149

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
Documentation (README or documentation) has been updated or is not required

✔️ TODO

Test this with an actual translation ai setup

mejo-

I didn't dive too deep into the changes, but a quick testing didn't work as expected. While the fake providers provided by the testing app worked, the providers provided by the translation app were not listed.

What I did to reproduce:

Disable app testing
Enable apps assistant and translate
Run occ translate:download-models

When I load the translation modal from the assistant menu with this PR applied, the dropdowns "translate from" and "translate to" are empty and don't provide any language. Maybe I missed something?

luka-nextcloud · 2024-11-19T09:36:04Z

@mejo- As I understand, the assistant app cannot work without testing app (or AI provider apps). So, disabling testing app means disabling assistant and translation. So, I think the test case doesn't make sense to me.

juliusknorr · 2024-11-21T06:58:12Z

There is also translate2, not sure if just an addition or successor. translate doesn't implement the new API.

@marcelklehr From an integration team perspective, is it work to keep both APIs available or is just going with the task processing API and ignoring the old translation API fine.

luka-nextcloud · 2024-11-21T09:53:20Z

In my opinion, we should go with the task processing API and ignore the old translation API since it might be complicated to maintain when keeping both APIs.

marcelklehr · 2024-11-21T12:22:46Z

We opted to implement neither forward nor backward compatibility for the old Translation API in TaskProcessing. The translate2 app only uses the TaskProcessing API, while the translate app uses the old Translation API. I'd recommend to transition to TaskProcessing directly if you don't need to support nc < 30, as the old Translation API is already deprecated and you will need to transition at some point. If it's too much work for you to add support for task processing, we can talk about adding forward and backward compatibility in server, but I'd rather avoid that.

mejo- · 2024-11-27T15:38:54Z

@luka-nextcloud I'm still unable to successfully test this using real translation providers. Did you test this with real providers, or just with the testing app?

What I did:

Disable app testing
1. Setup app_api environment as documented in https://docs.nextcloud.com/server/latest/admin_manual/ai/app_api_and_external_apps.html
Setup translate2 app as described in https://docs.nextcloud.com/server/latest/admin_manual/ai/app_translate2.html
Build this branch, select something in text and open the translate assistant modal.

Problems:

I cannot select a source language except "detect automatically"
Selecting "translate" does nothing.

When opening the assistant modal directly in the header bar (not via Text), translation works as expected, so I guess there's something wrong with the implementation in Text.

This is how the dropdowns for selecting languages in the translation modal via Text look in my tests:

Signed-off-by: Luka Trovic <[email protected]>

luka-nextcloud · 2024-12-04T11:47:07Z

@mejo- I have tested with both apps testing and translate2. BTW, if we use translate2, the from-language selection will only have 1 option "Detect Language"

marcelklehr · 2025-02-10T12:05:51Z

Note: integration_openai also implements a translation provider

max-nextcloud · 2025-02-10T12:18:13Z

/backport! to stable31

marcelklehr · 2025-02-10T12:27:13Z

Installed successulfy now. Translation menu entry in the AI menu doesn't do anything on click:

Error: Could not find initial state translation_can_detect of text
    e http://localhost:8080/apps/text/js/index-CJ7wDv5l.chunk.mjs:1
    data http://localhost:8080/apps/text/js/Editor-DCXGGTKZ.chunk.mjs:2
    vs http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    ds http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    ls http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    _init http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    s http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    Za http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    init http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    d http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    p http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    E http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    p http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    fc http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    _update http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    r http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    get http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    t http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    Va http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    $mount http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    init http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    c http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    i http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    Jg http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    _update http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    u http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    get http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    run http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    Th http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    Zn http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    _s http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
[vue.runtime.esm-DuKaSI2H.chunk.mjs:1:25024](http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs)
TypeError: this.languages is undefined
    fromLanguages http://localhost:8080/apps/text/js/Editor-DCXGGTKZ.chunk.mjs:2
    get http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    evaluate http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    lr http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    kA http://localhost:8080/apps/text/js/Editor-DCXGGTKZ.chunk.mjs:2
    _render http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    r http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    get http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    t http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    Va http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    $mount http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    init http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    d http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    p http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    E http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    p http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    fc http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    _update http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    r http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    get http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    t http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    Va http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    $mount http://localhost:8080/apps/text/js/vue.runtime.esm-DuKaSI2H.chunk.mjs:1
    init http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    c http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    i http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    Jg http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    _update http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    u http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    get http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    run http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    Th http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    Zn http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2
    _s http://localhost:8080/apps/viewer/js/logger-D5E9ePnd.chunk.mjs:2

juliusknorr · 2025-02-12T20:53:23Z

I can share credentials for easier testing with the integration_openai provider, just ping me if needed

max-nextcloud · 2025-02-14T09:04:18Z

@marcelklehr

Installed successulfy now. Translation menu entry in the AI menu doesn't do anything on click:

That looks like you did not compile it yet.
I told you you would not need to in chat - but I did not understand you were working on a feature branch / pull request. In text we have a compilation task that runs on the main and stable?? branches and provides the compiled js.

Could you try again? We can also jump on a call next week to try it together.

marcelklehr · 2025-02-14T10:54:50Z

Yeah, let's do that :)

marcelklehr · 2025-02-24T08:19:10Z

notes from test with new build:

On opening:

TypeError: this.toLanguage is null
    fromLanguage Translate.vue:157

when selecting a new "from language":

TypeError: newVal is null
    fromLanguage Translate.vue:157

Cannot retranslate after selecting a new "from language"

max-nextcloud

Tested this with @marcelklehr and the integration worked fine. There were two errors in the logs:

When changing the fromLanguage while toLanguage was not set yet
When clearing the toLanguage'.

Both pointed to line 157 of Tranlate.vue. I'll propose a change that will fix them.

In addition it would be good to also clear the result when the fromLanguage is changed - to allow for a recomputation.

Other than that this looks fine. I'll approve so you can fix the remaining things and then merge @luka-nextcloud

max-nextcloud · 2025-02-24T09:11:44Z

src/components/Modal/Translate.vue

+		fromLanguage(newVal) {
+			if (newVal.id === this.toLanguage.id) {
+				this.toLanguage = null
+			}
+		},


Fix the errors thrown in line 157 by handling null as newVal and this.toLanguage well.

When changing fromLanguage - also clear the result so it can be recomputed.

Suggested change

fromLanguage(newVal) {

if (newVal.id === this.toLanguage.id) {

this.toLanguage = null

}

},

fromLanguage(newVal) {

if (newVal?.id === this.toLanguage?.id) {

this.toLanguage = null

}

this.result = ''

this.error = null

},

luka-nextcloud added the 3. to review label Oct 28, 2024

luka-nextcloud requested review from max-nextcloud and mejo- as code owners October 28, 2024 15:35

mejo- requested changes Nov 4, 2024

View reviewed changes

juliusknorr added the bug Something isn't working label Nov 21, 2024

juliusknorr requested a review from mejo- November 25, 2024 14:52

luka-nextcloud self-assigned this Nov 25, 2024

fix: replace deprecated translation methods

08e25e1

Signed-off-by: Luka Trovic <[email protected]>

luka-nextcloud force-pushed the replace-deprecated-translation-methods branch from e879703 to 08e25e1 Compare December 4, 2024 11:46

max-nextcloud self-assigned this Dec 13, 2024

GVodyanov mentioned this pull request Jan 8, 2025

Add mail translation nextcloud/mail#10453

Merged

backportbot bot added the backport-request label Feb 10, 2025

backportbot bot mentioned this pull request Feb 10, 2025

[stable31] fix: replace deprecated translation methods #6895

Merged

backportbot bot removed the backport-request label Feb 10, 2025

juliusknorr added the backport-request label Feb 12, 2025

max-nextcloud approved these changes Feb 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: replace deprecated translation methods #6567

fix: replace deprecated translation methods #6567

luka-nextcloud commented Oct 28, 2024 •

edited by max-nextcloud

Loading

mejo- left a comment

luka-nextcloud commented Nov 19, 2024

juliusknorr commented Nov 21, 2024

luka-nextcloud commented Nov 21, 2024

marcelklehr commented Nov 21, 2024 •

edited

Loading

mejo- commented Nov 27, 2024

luka-nextcloud commented Dec 4, 2024

marcelklehr commented Feb 10, 2025

max-nextcloud commented Feb 10, 2025

marcelklehr commented Feb 10, 2025

juliusknorr commented Feb 12, 2025

max-nextcloud commented Feb 14, 2025

marcelklehr commented Feb 14, 2025

marcelklehr commented Feb 24, 2025

max-nextcloud left a comment

max-nextcloud Feb 24, 2025

fix: replace deprecated translation methods #6567

Are you sure you want to change the base?

fix: replace deprecated translation methods #6567

Conversation

luka-nextcloud commented Oct 28, 2024 • edited by max-nextcloud Loading

📝 Summary

🏁 Checklist

✔️ TODO

mejo- left a comment

Choose a reason for hiding this comment

luka-nextcloud commented Nov 19, 2024

juliusknorr commented Nov 21, 2024

luka-nextcloud commented Nov 21, 2024

marcelklehr commented Nov 21, 2024 • edited Loading

mejo- commented Nov 27, 2024

luka-nextcloud commented Dec 4, 2024

marcelklehr commented Feb 10, 2025

max-nextcloud commented Feb 10, 2025

marcelklehr commented Feb 10, 2025

juliusknorr commented Feb 12, 2025

max-nextcloud commented Feb 14, 2025

marcelklehr commented Feb 14, 2025

marcelklehr commented Feb 24, 2025

max-nextcloud left a comment

Choose a reason for hiding this comment

max-nextcloud Feb 24, 2025

Choose a reason for hiding this comment

luka-nextcloud commented Oct 28, 2024 •

edited by max-nextcloud

Loading

marcelklehr commented Nov 21, 2024 •

edited

Loading