Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure languages used for spell checking #771

Open
st3iny opened this issue Aug 26, 2024 · 4 comments · May be fixed by #855
Open

Configure languages used for spell checking #771

st3iny opened this issue Aug 26, 2024 · 4 comments · May be fixed by #855
Assignees
@ShGKme
Labels
2. developing enhancement New feature or request
Milestone
🪴 Next Release

Comments

@st3iny
Copy link
Member

st3iny commented Aug 26, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently, the spell checker defaults to the system's language on Linux. In my case this is German. However, I mostly communicate in English on Talk and the spell checker constantly shows the red underline below each word because it doesn't understand English.

image

Describe the solution you'd like
Let users configure languages used for spell checking.

Describe alternatives you've considered
Change my system's language. This won't fix the issue as I'm communication both in German and English regularly in Talk.

Additional context
Here is a hack I'm currently using that works:

diff --git a/src/talk/talk.window.js b/src/talk/talk.window.js
index 6d69246..680847b 100644
--- a/src/talk/talk.window.js
+++ b/src/talk/talk.window.js
@@ -67,6 +67,9 @@ function createTalkWindow() {
        applyWheelZoom(window)
        setupTray(window)

+       // Configure the spell checker to use English (US) and German
+       window.webContents.session.setSpellCheckerLanguages(['en-US', 'de'])
+
        window.loadURL(TALK_WINDOW_WEBPACK_ENTRY)

        return window
@st3iny st3iny added enhancement New feature or request 0. Needs triage labels Aug 26, 2024
@nextcloud nextcloud deleted a comment Aug 26, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Aug 26, 2024

A simple solution - use system language + Nextcloud user settings.

An alternative - provide a setting with the list of all the options.

@ShGKme
Copy link
Contributor

ShGKme commented Aug 26, 2024

Will go with use system languages as the default + local settings.

@ShGKme ShGKme linked a pull request Oct 28, 2024 that will close this issue
Draft
1 task
@ShGKme ShGKme self-assigned this Oct 30, 2024
@schiessle
Copy link
Member

schiessle commented Dec 11, 2024 •
edited
Loading

I think there should be also a easy way to switch the language. On the browser I can right-click into the input field and select one or multiple languages. This is really helpful if you switch regular between languages. As the desktop app also uses some kind of an "embedded browser" I wonder if there is a way to expose this language switcher?

Maybe I'm special in this regard but both my operating system and Nextcloud are set to English but I also have chats regularly in German. So a easy way to switch the spell checker would be really helpful, or set it to check for both languages by default.

@ShGKme ShGKme mentioned this issue Jan 17, 2025
Open
@handkerchief333
Copy link

I have the same problem. Is there no checkbox in the settings for the spell checker to disable this function? If so, I can't find it.

Because you can't use this program if you write in the “wrong” language. The red marks are too annoying and distracting. My system language is English, but I often write in German, but also in English, which varies from person to person.

I would like to be able to simply deactivate this feature, because no matter which language I would select, It is the wrong language in another chat/time.

@ShGKme ShGKme added this to the 🪴 Next Release milestone Feb 3, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Feb 3, 2025
@ShGKme ShGKme moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💬 Talk team Feb 3, 2025
@ShGKme ShGKme modified the milestones: v1.1.3-beta, 🪴 Next Release Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
2. developing enhancement New feature or request
Projects
💬 Talk team
Status: 🏗️ In progress
Milestone
🪴 Next Release
Development

Successfully merging a pull request may close this issue.

feat: add spell checking config nextcloud/talk-desktop
5 participants
@nickvergessen @st3iny @schiessle @ShGKme @handkerchief333