Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗑️ 💬 Clear chat history - Backend #5889

Merged
merged 5 commits into from
Jul 7, 2021
Merged

🗑️ 💬 Clear chat history - Backend #5889

merged 5 commits into from
Jul 7, 2021

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 28, 2021 •
edited
Loading

  • API to clear the history
  • Unshare all files
  • Document it
  • System message "A has removed the history of the conversation"
  • Integration test

Fix #1243

@nickvergessen nickvergessen added 2. developing enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jun 28, 2021
@nickvergessen nickvergessen added this to the 💖 Next Major (23) milestone Jun 28, 2021
@nickvergessen nickvergessen self-assigned this Jun 28, 2021
@nickvergessen nickvergessen changed the title Clear history Clear chat history Jun 28, 2021
@nickvergessen nickvergessen changed the title Clear chat history 🗑️ 💬 Clear chat history Jun 28, 2021
@nickvergessen
Clear history
d766314 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Remove shares and fix the message markers
81922ee 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add integration test
bbed7ef 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/1243/clear-history branch from fd5efcf to bbed7ef Compare July 7, 2021 14:11
@nickvergessen
Add unit tests
31a32b6 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen marked this pull request as ready for review July 7, 2021 14:39
@nickvergessen nickvergessen changed the title 🗑️ 💬 Clear chat history 🗑️ 💬 Clear chat history - Backend Jul 7, 2021
@nickvergessen nickvergessen mentioned this pull request Jul 7, 2021
Closed
PVince81
PVince81 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 some minor comments

@nickvergessen
Change system message string
b138414 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 7, 2021 •
edited
Loading

Backport to stable22

  • ChatManager::deleteMessages() share removal
  • ChatController::deleteMessage() header
  • Integration test missing version

@nickvergessen
Copy link
Member Author

/backport to stable22.1

PVince81
PVince81 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit dbc294f into master Jul 7, 2021
@PVince81 PVince81 deleted the feature/1243/clear-history branch July 7, 2021 15:44
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 7, 2021
Merged
@nickvergessen nickvergessen mentioned this pull request Jul 8, 2021
Merged
@Ivansss
Copy link
Member

Ivansss commented Jul 15, 2021

Capability clear-history is missing :/

@PVince81
Copy link
Member

Capability clear-history is missing :/

added with #6023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@nickvergessen nickvergessen

Labels
4. to release enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v13.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Allow to clear chat history
3 participants
@nickvergessen @Ivansss @PVince81