Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🆕 Read marker handling based on ID and settable via API #1214

Merged
merged 6 commits into from
Jul 25, 2019
Merged

🆕 Read marker handling based on ID and settable via API #1214

merged 6 commits into from
Jul 25, 2019

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 26, 2018 •
edited
Loading

  • Fix writing of last_mention_message
  • Add endpoint to set the last_read_message
  • Adjust unit tests
  • Correctly set the read marker from the web UI
  • Fix the loading of the chat messages as described in Chat flow experience #1164
  • People added later should have the marker set to !== 0 so they are at the bottom and not the start.

Rel #1164
Rel #1788

@nickvergessen nickvergessen added 2. developing feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Sep 26, 2018
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Sep 26, 2018
@nickvergessen nickvergessen self-assigned this Sep 26, 2018
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-marker branch from d379cd6 to 14bb2f8 Compare September 27, 2018 10:00
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-marker branch from 3845d9c to 30ae8fb Compare October 1, 2018 10:09
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-marker branch from 30ae8fb to 3381c26 Compare October 5, 2018 12:59
@nickvergessen nickvergessen mentioned this pull request Oct 5, 2018
Closed
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-marker branch from 3381c26 to bd14622 Compare October 9, 2018 13:00
@nickvergessen nickvergessen mentioned this pull request Oct 15, 2018
Closed
5 tasks
@nickvergessen nickvergessen mentioned this pull request May 8, 2019
Closed
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-marker branch from bd14622 to 30c6d8b Compare May 16, 2019 13:48
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-marker branch from 30c6d8b to 54692eb Compare July 24, 2019 13:14
@nickvergessen
Copy link
Member Author

Ready to review now, because it is a pre-requirement to #2020

The behaviour is the same as before, unless a client wants to handle read-marking themselves. Then they just await new messages with setReadMarker=0 (see docs) and instead manually set it via Mark chat as read. This would allow to fetch messages, but only update the read marker when you scroll to actual new messages.

@nickvergessen
Add a capability
30c5d02 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/noid/unread-message-marker branch from 99d1b67 to 30c5d02 Compare July 24, 2019 13:37
@nickvergessen nickvergessen changed the title Unread message marker Read marker handling based on ID and settable via API Jul 24, 2019
@nickvergessen nickvergessen changed the title Read marker handling based on ID and settable via API 🆕 Read marker handling based on ID and settable via API Jul 24, 2019
@nickvergessen nickvergessen changed the title 🆕 Read marker handling based on ID and settable via API 🏷 Read marker handling based on ID and settable via API Jul 24, 2019
@nickvergessen nickvergessen changed the title 🏷 Read marker handling based on ID and settable via API 🆕 Read marker handling based on ID and settable via API Jul 24, 2019
Ivansss
Ivansss approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘
Doesn't seem to break anything

@nickvergessen nickvergessen merged commit db48265 into master Jul 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/unread-message-marker branch July 25, 2019 11:48
@nickvergessen nickvergessen mentioned this pull request Jul 25, 2019
Merged
4 tasks
This was referenced Aug 26, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages high
Projects
None yet
Milestone
7.0.0-beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @Ivansss @danxuliu