Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Signaling documentation. #1147

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Aug 23, 2018

Fix #1144

@Ivansss Ivansss added 3. to review feature: signaling 📶 Internal and external signaling backends labels Aug 23, 2018
@Ivansss Ivansss added this to the 💚 Next Major milestone Aug 23, 2018
@Ivansss Ivansss force-pushed the bugfix/1144/add-signaling-documentation branch from 7110ead to d705857 Compare August 23, 2018 15:15
Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also describe the contents of entries in stunservers and turnservers.

@Ivansss
Copy link
Member Author

Ivansss commented Aug 24, 2018

Done

field | type | Description
------|------|------------
`url` | array | One element array with TURN server URL
`urls` | array | One element array with TURN server URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url and urls?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what we send at the moment. I already discussed with @fancycode some changes here.
But they will require changes in mobiles apps as well.

Copy link
Member

@fancycode fancycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ivansss Ivansss merged commit e18128a into master Aug 24, 2018
@Ivansss Ivansss deleted the bugfix/1144/add-signaling-documentation branch August 24, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants