Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System check for call participants #1181

Closed
karlitschek opened this issue Sep 9, 2018 · 5 comments · Fixed by #11624
Closed

System check for call participants #1181

karlitschek opened this issue Sep 9, 2018 · 5 comments · Fixed by #11624

Comments

@karlitschek
Copy link
Member

Skype and others provide a way to check the system before call.For example record some voice and play it back. Show the webcam video. Test upstream/downstream speed. Test CPU speed...
It would be great if the use could also start this kind of test to check if everything is ok for a call. This also increases the happyiness of the users with Talk because they realize that the software is not broken but the PC is not working properly.

@fancycode
Copy link
Member

This could be based on https://github.com/webrtc/testrtc (BSD, online at https://test.webrtc.org/).

@nickvergessen nickvergessen added this to the 💔 Backlog milestone Sep 24, 2018
@nickvergessen nickvergessen added enhancement feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients labels Sep 24, 2018
@madmath03
Copy link

I think it would be a really nice feature to have and I actually see 2 ways to display it:

  • for "regular" users (part of NextCloud), this would make sense to have something like a configuration button where the user can check its computer when they feel the need to.
  • for "external" users (invited through public link), this check should be mandatory and displayed before showing the room

Best would probably be to keep track through session / cookies if the user checked its system at least and if not, force the system check.

What do you think ?

@mokkin
Copy link
Contributor

mokkin commented Apr 21, 2020

Here is how Edudip does it:

systemcheck

@nickvergessen
Copy link
Member

nickvergessen commented Aug 23, 2023

  • Camera: available now in the media settings screen right before the call
  • Mic: media settings screen shows icon with filling color content of the audio level

Remaining ideas:

  • Audio Output: Add the "voice message" option on the media settings screen to allow recording and then playing back? Or a simple "bing" sound for testing?
  • Ports/WebRTC: just do a check like in the admin settings?
  • Upstream/Downstream: we improved quite a lot with quality selection etc. and voice calls should be doable most of the time. If not the connection warning during the call should show it. Is it still necessary?

cc @nextcloud/designers for feedback

@nickvergessen nickvergessen changed the title system check system check for call participants Aug 23, 2023
@nickvergessen nickvergessen changed the title system check for call participants System check for call participants Aug 23, 2023
@nickvergessen nickvergessen added feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls and removed feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients labels Aug 23, 2023
@marcoambrosini
Copy link
Member

Upstream/Downstream: we improved quite a lot with quality selection etc. and voice calls should be doable most of the time. If not the connection warning during the call should show it. Is it still necessary?

I think the connection warning should be enough.

Ports/WebRTC: just do a check like in the admin settings?

This we probably shouldn't show the users and should also fall in the previous category of "connection warning".
We could have a small indicator about the connection that groups everything.

Audio Output: Add the "voice message" option on the media settings screen to allow recording and then playing back? Or a simple "bing" sound for testing?

We could definitely at least improve the audio indicator and add a test

@jancborchardt jancborchardt moved this to 🧭 Planning evaluation / ideas in 🖍 Design team Dec 14, 2023
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Dec 14, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Dec 14, 2023
@jancborchardt jancborchardt moved this from 🧭 Planning evaluation / ideas to 🏗️ At engineering in 🖍 Design team Dec 14, 2023
@DorraJaouad DorraJaouad self-assigned this Feb 21, 2024
@DorraJaouad DorraJaouad moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💬 Talk team Feb 21, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💬 Talk team Mar 5, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Mar 5, 2024
@Antreesy Antreesy modified the milestones: 💔 Backlog, v19.0.0-beta.1 Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants