Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable12] Fix translation bug on lost password page #9549

Merged
merged 1 commit into from
May 22, 2018

Conversation

remyj38
Copy link
Contributor

@remyj38 remyj38 commented May 22, 2018

During resetting user's password, the controller return the untranslated message (from basic exception) instead of the hint message (translated).

Fix nextcloud/password_policy#26

Signed-off-by: Rémy Jacquin [email protected]

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels May 22, 2018
@ChristophWurst ChristophWurst added this to the Nextcloud 12.0.8 milestone May 22, 2018
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #9549 into stable12 will decrease coverage by <.01%.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             stable12    #9549      +/-   ##
==============================================
- Coverage       53.91%   53.91%   -0.01%     
- Complexity      22785    22786       +1     
==============================================
  Files            1387     1387              
  Lines           87300    87302       +2     
  Branches         1331     1331              
==============================================
+ Hits            47070    47071       +1     
- Misses          40230    40231       +1
Impacted Files Coverage Δ Complexity Δ
core/Controller/LostController.php 80.13% <50%> (-0.41%) 30 <0> (+1)

@MorrisJobke MorrisJobke merged commit 2c64557 into nextcloud:stable12 May 22, 2018
@MorrisJobke MorrisJobke mentioned this pull request May 31, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants