Remove white background from loading icon #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allows to use the loading icon on non-white background (disabled input fields for example) * fixes #2466 Signed-off-by: Morris Jobke <[email protected]>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Henni, @blizzz and @rullzer to be potential reviewers. |
|
Good catch, works nicely 👍 (Also saw it yesterday briefly and assumed it was the gif. :D) |
|
👍 |
|
👍 @jancborchardt I'm working on the gif! |
|
@skjnldsv awesome! That would be a great detail fix for Nextcloud 11 indeed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nextcloud/designers @enoch85 @rullzer @skjnldsv @juliushaertl @nickvergessen @schiessle
I tested this in Firefox, Safari, Chrome, Edge and IE11