Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable share emails #22297

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Allow to disable share emails #22297

merged 1 commit into from
Aug 19, 2020

Conversation

nickvergessen
Copy link
Member

Fix #15929

@nickvergessen
Allow to disable share emails
c8f175e 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Aug 19, 2020
@nickvergessen
Copy link
Member Author

/backport to stable19

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 19, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 19, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31953: failure

jsunit

Show full log 
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (15.03 secs / 14.179 secs)

acceptance-app-files

  • failure block could not be found - most likely this run got canceled
Show full log 
+ tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-app-files --selenium-server selenium:4444 allow-git-repository-modifications features/app-files.feature
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 48 installs, 0 updates, 0 removals
  - Installing instaclick/php-webdriver (1.4.7): Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (5%)����������������Downloading (20%)�����������������Downloading (25%)�����������������Downloading (30%)�����������������Downloading (35%)�����������������Downloading (45%)�����������������Downloading (60%)�����������������Downloading (65%)�����������������Downloading (70%)�����������������Downloading (90%)�����������������Downloading (95%)�����������������Downloading (100%)
  - Installing symfony/css-selector (v3.4.43): Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (5%)����������������Downloading (10%)�����������������Downloading (15%)�����������������Downloading (35%)�����������������Downloading (40%)�����������������Downloading (45%)�����������������Downloading (50%)�����������������Downloading (55%)�����������������Downloading (60%)�����������������Downloading (65%)�����������������Downloading (70%)�����������������Downloading (75%)�����������������Downloading (80%)�����������������Downloading (85%)�����������������Downloading (90%)�����������������Downloading (95%)�����������������Downloading (100%)
  - Installing behat/mink (v1.7.1): Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (5%)����������������Downloading (10%)�����������������Downloading (15%)�����������������Downloading (20%)�����������������Downloading (25%)�����������������Downloading (30%)�����������������Downloading (35%)�����������������Downloading (40%)�����������������Downloading (45%)�����������������Downloading (50%)�����������������Downloading (55%)�����������������Downloading (60%)�����������������Downloading (65%)�����������������Downloading (70%)�����������������Downloading (75%)�����������������Downloading (80%)�����������������Downloading (85%)�����������������Downloading (90%)�����������������Downloading (95%)�����������������Downloading (100%)
  - Installing behat/mink-selenium2-driver (v1.3.1): Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (40%)�����������������Downloading (95%)�����������������Downloading (100%)
  - Installing symfony/polyfill-ctype (v1.18.1): Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (100%)
  - Installing symfony/filesystem (v5.1.3): Downloading (connecting...)
Downloading (connecting...)���������������������������Downloading (failed)       �������
Downloading (connecting...)���������������������������Downloading (failed)       �������    Failed to download symfony/filesystem from dist: The "https://api.github.com/repos/symfony/filesystem/zipball/6e4320f06d5f2cce0d96530162491f4465179157" file could not be downloaded: php_network_getaddresses: getaddrinfo failed: Name or service not known
failed to open stream: php_network_getaddresses: getaddrinfo failed: Name or service not known
    Now trying to download from source
  - Installing symfony/filesystem (v5.1.3): Cloning 6e4320f06d

                                                                                                              
  [RuntimeException]                                                                                          
  Failed to clone https://github.com/symfony/filesystem.git via https, ssh protocols, aborting.               
                                                                                                              
  - https://github.com/symfony/filesystem.git                                                                 
    Cloning into '/drone/src/tests/acceptance/vendor/symfony/filesystem'...                                   
    fatal: unable to access 'https://github.com/symfony/filesystem.git/': Could not resolve host: github.com  
                                                                                                              
  - [email protected]:symfony/filesystem.git                                                                     
    Cloning into '/drone/src/tests/acceptance/vendor/symfony/filesystem'...                                   
    ssh: connect to host github.com port 22: Connection timed out                                             
    fatal: Could not read from remote repository.                                                             
                                                                                                              
    Please make sure you have the correct access rights                                                       
    and the repository exists.                                                                                
                                                                                                              

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

acceptance-app-files-sharing-link

  • failure block could not be found - most likely this run got canceled
Show full log 
+ tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-app-files-sharing-link --selenium-server selenium:4444 allow-git-repository-modifications features/app-files-sharing-link.feature
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 48 installs, 0 updates, 0 removals
  - Installing instaclick/php-webdriver (1.4.7): Downloading (connecting...)���������������������������Downloading (100%)         ���������
Downloading (connecting...)���������������������������Downloading (failed)       �������
Downloading (connecting...)���������������������������Downloading (failed)       �������    Failed to download instaclick/php-webdriver from dist: The "https://api.github.com/repos/instaclick/php-webdriver/zipball/b5f330e900e9b3edfc18024a5ec8c07136075712" file could not be downloaded: php_network_getaddresses: getaddrinfo failed: Name or service not known
failed to open stream: php_network_getaddresses: getaddrinfo failed: Name or service not known
    Now trying to download from source
  - Installing instaclick/php-webdriver (1.4.7): Cloning b5f330e900

                                                                                                                                      
  [RuntimeException]                                                                                                                  
  Failed to clone https://github.com/instaclick/php-webdriver.git via https, ssh protocols, aborting.                                 
                                                                                                                                      
  - https://github.com/instaclick/php-webdriver.git                                                                                   
    Cloning into '/drone/src/tests/acceptance/vendor/instaclick/php-webdriver'...                                                     
    fatal: unable to access 'https://github.com/instaclick/php-webdriver.git/': GnuTLS recv error (-54): Error in the pull function.  
                                                                                                                                      
  - [email protected]:instaclick/php-webdriver.git                                                                                       
    Cloning into '/drone/src/tests/acceptance/vendor/instaclick/php-webdriver'...                                                     
    Host key verification failed.                                                                                                     
    fatal: Could not read from remote repository.                                                                                     
                                                                                                                                      
    Please make sure you have the correct access rights                                                                               
    and the repository exists.                                                                                                        
                                                                                                                                      

install [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--ignore-platform-reqs] [--] [<packages>]...

object-store-s3

memcache-memcached

@nickvergessen nickvergessen merged commit 4ff492a into master Aug 19, 2020
@nickvergessen nickvergessen deleted the feature/15929/allow-to-disable-share-emails branch August 19, 2020 07:50
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

E-mail notification of activities despite deactivation
4 participants
@nickvergessen @rullzer @blizzz @juliusknorr