Respect exit code of lint run - changed from -exec to xargs as this exits properly #20952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
|
/backport to stable16 |
ChristophWurst
approved these changes
May 13, 2020
rullzer
approved these changes
May 13, 2020
…xits properly Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
test/noid/fix-lint-exit-code
branch
from
28627f8 to
8614aba
Compare
MorrisJobke
added
4. to release
|
rebase time! |
This was referenced May 13, 2020
Already done ... now there are errors 🙈 |
Signed-off-by: Morris Jobke <[email protected]>
georgehrke
approved these changes
May 13, 2020
|
The backport to stable19 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
|
The backport to stable17 failed. Please do this backport manually. |
|
The backport to stable16 failed. Please do this backport manually. |
|
Stable 16-18 don't need this. |
This was referenced May 13, 2020
|
Oh fun. I'll merge it into my app as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while debugging #20951
So this one will fail for now until #20951 is merged. Then I will rebase.