Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the total used space per user #11417

Merged
merged 4 commits into from
Sep 28, 2018
Merged

Add back the total used space per user #11417

merged 4 commits into from
Sep 28, 2018

Conversation

skjnldsv
Copy link
Member

Fix #11217

@skjnldsv
Add back the total used space per user
1aa0990 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Sep 27, 2018
@skjnldsv skjnldsv self-assigned this Sep 27, 2018
@skjnldsv
Fix string formatting
7c15d9e 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
JSoko
JSoko approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@JSoko JSoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works, thank You!

@rullzer
Copy link
Member

rullzer commented Sep 27, 2018

CI not happy

ChristophWurst
ChristophWurst approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Can be merged once CI is happy

@JSoko
Copy link
Member

JSoko commented Sep 28, 2018

One small thing:
For users who use 0kb ist shows "unknown Space used"
Bug or feauture?
grafik

@skjnldsv
Copy link
Member Author

@JSoko feature. The user did not logged in yet so the user folder doesn't exists.
Though I can say it's better for the user to see 0kb used even if it's not really true :)

I'll change this!

@skjnldsv
Fix class selector for acceptance tests
f5f31e2 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
State default unknown quota to 0
8a2ac44 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv merged commit ecf33a6 into master Sep 28, 2018
@skjnldsv skjnldsv deleted the hover-quota-used-space-regression branch September 28, 2018 06:59
@skjnldsv skjnldsv mentioned this pull request Sep 28, 2018
Merged
@skjnldsv
Copy link
Member Author

Backport on #11425

This was referenced Oct 3, 2018
Closed
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JSoko JSoko JSoko approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: users and groups regression
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @rullzer @JSoko @ChristophWurst