Smtp auth failure when sharing a file does not update the sharing list

[skjnldsv]

Steps to reproduce

1. have an invalid php email set in the additional settings
2. share a directory with a user

Expected behaviour

• The sharing list is immediately updated and an error message is shown saying 'share added but there was an issue sending the mail'

Actual behaviour

• Loading icon during 15 sec
• Error saying no mail has been sent
• Shares list not updated despite the fact that the share has been set

Server configuration

Operating system: Arch

Web server: Nginx

Database: mariadb

PHP version: 7.2

Nextcloud version: 13

Updated from an older Nextcloud/ownCloud or fresh install: updated

Request log:
{"ocs":{"meta":{"status":"failure","statuscode":403,"message":"Failed to authenticate on SMTP server with username \"[email protected]\" using 1 possible authenticators"},"data":[]}}

[MorrisJobke]

We shouldn't leak this via our API 🙈 cc @rullzer @nickvergessen

[MorrisJobke]

@ChristophWurst

[nickvergessen]

For me the API returns 'Failed to send share by mail'
The named message is only in the logs, which I think is fine.
Relevant code:

server/apps/sharebymail/lib/ShareByMailProvider.php

Lines 346 to 374 in b93aa58

	try {
	$link = $this->urlGenerator->linkToRouteAbsolute('files_sharing.sharecontroller.showShare',
	['token' => $share->getToken()]);
	$this->sendMailNotification(
	$share->getNode()->getName(),
	$link,
	$share->getSharedBy(),
	$share->getSharedWith(),
	$share->getExpirationDate()
	);
	} catch (HintException $hintException) {
	$this->logger->logException($hintException, [
	'message' => 'Failed to send share by mail.',
	'level' => ILogger::ERROR,
	'app' => 'sharebymail',
	]);
	$this->removeShareFromTable($shareId);
	throw $hintException;
	} catch (\Exception $e) {
	$this->logger->logException($e, [
	'message' => 'Failed to send share by mail.',
	'level' => ILogger::ERROR,
	'app' => 'sharebymail',
	]);
	$this->removeShareFromTable($shareId);
	throw new HintException('Failed to send share by mail',
	$this->l->t('Failed to send share by email'));
	}

[nickvergessen]

Code is also like this in stable13+ so I'm closing this one year old issue.
Feel free to reopen when you have other steps to reproduce