Preview cache issue

[PhieF]

I'm using previewgenerator app to pre-generate my thumbnails however I'm encountering an issue that could come from the preview engine.
in
private/Preview/Generator.php

we have

try {  
    $preview = $this->getCachedPreview($previewFolder, $width, $height, $crop, $maxPreview->mimeType);

  } catch (NotFoundException $e) {
          $preview = $this->generatePreview($previewFolder, $maxPreview, $width, $height, $crop, $maxWidth, $maxHeight);

}

I've added the same

$preview = $this->getCachedPreview($previewFolder, $width, $height, $crop, $maxPreview->mimeType);

after generatePreview
Here, getCachedPreview should have been able to find a preview, however it still can't find a cached preview.
It seems the problem comes from "$maxPreview->mimeType" which I don't understand the purpose, why shouldn't it be "$mimeType"
?

Thank you

[MorrisJobke]

cc @rullzer

[rullzer]

It has to be the mimetype of the preview. For example consider you are making an preview for some MP3 file that has album data in it. The resulting preview will be a jpeg or png. But the mimetype of the file is that of an mp3 file (audio/mpeg ??).

Do you have an example image that you see this behaviour with? As I can't trigger it locally.

[PhieF]

Hi,

an example would be this one
https://nextcloud.phoenamandre.fr/index.php/s/W5RiEp35d8LQENA
which would raise this kind of exception

OCP\Files\NotFoundException: /appdata_ocy1zr9xjp8r/preview/36128/192-128.png in /var/www/html/nextcloud/lib/private/Files/Node/Root.php:202

here is what I have in this folder

1024-1024-crop.jpg
1116-1116-crop.jpg
128-85.jpg
192-128.jpg
256-256-crop.png
32-32-crop.png
512-342.jpg
64-43.jpg
767-512.jpg
1024-1024-crop.png
128-128-crop.jpg
1534-1024.jpg
256-171.jpg
32-21.jpg
384-256.jpg
512-512-crop.jpg
64-64-crop.jpg
96-64.jpg
1024-683.jpg
128-128-crop.png
1672-1116-max.png
256-256-crop.jpg
32-32-crop.jpg
48-32.jpg
512-512-crop.png
64-64-crop.png

so a lot of things, but not the asked preview

I was wondering, do we have a max cache size somewhere ?

[rullzer]

Ah Mmm I think this is caused by a bug that is fixed recently. Does this also happen for newly uploaded files?

[PhieF]

I don't know for newly uploaded files, I will try, thanks ! Fixed and released ? I'm on beta channel
Well it seems I have the latest commit

[MorrisJobke]

I don't know for newly uploaded files, I will try, thanks ! Fixed and released ? I'm on beta channel
Well it seems I have the latest commit

@rullzer Do you know by any chance if this is already released?

[rullzer]

Ah yes it is in 13. The issue was that we always saved a file as png. While it not always is a png. This caused some browsers to not play nice.

This looks like the leftovers of that. I'll think if I can come up with a way to clean this all up properly :S