Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable 12, user page, console warning #5115

Closed
michaelletzgus opened this issue May 25, 2017 · 4 comments
Closed

Stable 12, user page, console warning #5115

michaelletzgus opened this issue May 25, 2017 · 4 comments

Comments

@michaelletzgus
Copy link
Contributor

Stable 12 (upgrade from 11.3 via upgrade app), loading users page.

js console says:

Missing argument $row in OC.Notification.hide() call, caller needs to be adjusted to only dismiss its own notification merged-template-prepend.js:2246:4

@LukasReschke
Copy link
Member

Naive guess: related to #5114 (comment)

@michaelletzgus
Copy link
Contributor Author

michaelletzgus commented May 28, 2017

Thanks for the hint - this resolves the missing message and the warning message in the console.
Now I have message like

Fehler beim Anlegen des Benutzers: {message}

@ChristophWurst
Copy link
Member

Missing argument $row in OC.Notification.hide() call, caller needs to be adjusted to only dismiss its own notification merged-template-prepend.js:2246:4

This is just a warning because some code (partly in apps) has not been adjusted to this change yet. Everything should work nevertheless.

@MorrisJobke
Copy link
Member

We are trying to get rid of all the Notification.hide() calls in the future. As of now you can safely ignore it, because the fallback code is still in place. It's basically a warning for us. As this is in the server code we will properly find it and replace it with the correct code. It's only helpful for developers of apps, that they know that there needs something improved on their side as well.

Thanks for the report anyway 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants