Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ocs/v2.php/core/navigation/apps?absolute=true returns invalid url #43204

Closed
5 of 8 tasks
camilasan opened this issue Jan 30, 2024 · 3 comments · Fixed by #43251
Closed
5 of 8 tasks

[Bug]: ocs/v2.php/core/navigation/apps?absolute=true returns invalid url #43204

camilasan opened this issue Jan 30, 2024 · 3 comments · Fixed by #43251
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 26-feedback bug

Comments

@camilasan
Copy link
Member

camilasan commented Jan 30, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

In Nextcloud 26, with the app nextcloud/external - I have consulted @provokateurin about it - if I request:
curl -u user:pwd -X GET 'http://stable26.local/ocs/v2.php/core/navigation/apps?absolute=true' -H "OCS-APIRequest: true"

It returns:
<href>http://stable26.local/https://duckduckgo.com</href>

If I request without absolute=true then I get:
<href>https://duckduckgo.com</href>

Steps to reproduce

  1. Install the External Sites app
  2. Add 2 urls - somehow, the issue was only reproducible after adding a second link.

Expected behavior

ocs/v2.php/core/navigation/apps?absolute=true should return a valid url in href.

Installation method

Community Docker image

Nextcloud Server version

26

Operating system

Debian/Ubuntu

PHP engine version

Other

Web server

Nginx

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@camilasan camilasan added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 30, 2024
@sorbaugh
Copy link
Contributor

@come-nc I'm uncertain if the issue is on the external_sites app itself or if it's a server/core issue. What do you think?

@provokateurin
Copy link
Member

I had a look at the code in the external app and it adds the href as-is to the navigation entries. It should be verified that this also is received correctly on the server site, but I'm pretty sure it is.

@sorbaugh
Copy link
Contributor

I had a look at the code in the external app and it adds the href as-is to the navigation entries. It should be verified that this also is received correctly on the server site, but I'm pretty sure it is.

Yes then it sounds like a server/core issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 26-feedback bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants