Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Contents inside shared directory can be "Unshared" but are effectively deleted #43130

Closed
4 of 8 tasks
ChristophWurst opened this issue Jan 25, 2024 · 5 comments · Fixed by #43152
Closed
4 of 8 tasks
Assignees
Labels

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 25, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Inside a shared folder I can trigger an Unshare of of all files/folders. When I execute the action, the files are deleted for the sharerer.

image

Unshare should only be shown for the element that is shared, not it's children.

Steps to reproduce

  1. Create user1 and user2
  2. Create "Shared folder" as user1
  3. Upload a picture into "Shared folder" as user1
  4. Share "Shared folder" with user2
  5. Log in as user2
  6. Go to "Shared folder"
  7. Open the actions menu of the picture
  8. Click Unshare (and note how there is no Delete)
  9. Log in as user1
  10. Open "Shared folder"

Expected behavior

The picture is still there because user2 only unshared but didn't delete. At least that is what the UI says.

Installation method

None

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ChristophWurst
Copy link
Member Author

Tested on 28.0.2 RC2 and ddc22c8. cc @sorbaugh

@sorbaugh sorbaugh added this to the Nextcloud 28.0.3 milestone Jan 26, 2024
@sorbaugh
Copy link
Contributor

Thanks for reporting this. @fenn-cs for some reason Unshare is behaving like Delete (and Delete is missing).

@szaimen
Copy link
Contributor

szaimen commented Jan 26, 2024

also cc @nextcloud/server-frontend

@netzpolitikorg
Copy link

we can reproduce, too 😭

@skjnldsv skjnldsv self-assigned this Jan 26, 2024
@skjnldsv
Copy link
Member

It's my fault #42584

  • if a file doesn't belong to you AND is shared: it's Unshare
  • if a file doesn't belong to you AND is not shared, it's probably a file within a shared folder and then, it should be Delete

But it's only a visual cue, there's no backend change

@skjnldsv skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 26, 2024
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants