Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary 2FA UI message in Files settings #42647

Open
pboguslawski opened this issue Jan 9, 2024 · 2 comments · May be fixed by #44594
Open

Unnecessary 2FA UI message in Files settings #42647

pboguslawski opened this issue Jan 9, 2024 · 2 comments · May be fixed by #44594
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@pboguslawski
Copy link
Contributor

2FA message

server/apps/files/src/views/Settings.vue

Line 84 in fdc64ea

{{ t('files', 'If you have enabled 2FA, you must create and use a new app password by clicking here.') }} ↗
should not be rendered if 2FA is not enabled in system to keep UI clean.
@solracsf solracsf added enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Jan 9, 2024
@joshtrichards joshtrichards changed the title Unnecessary 2FA UI message Unnecessary 2FA UI message in Files settings Jan 9, 2024
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jan 11, 2024
@nadasuhailAyesh12
Copy link

so you want to delete this UI message ,right. Can I take this issue and proceed a PR .I need a merged PR for my university assignment.

This was referenced Mar 30, 2024
Closed
Open
@XxTysweezyxX
Copy link
Contributor

I'd like to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
6 participants
@joshtrichards @pboguslawski @solracsf @skjnldsv @nadasuhailAyesh12 @XxTysweezyxX