Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Don't cache quota when queried in web UI #35421

Closed
5 of 9 tasks
PVince81 opened this issue Nov 25, 2022 · 2 comments
Closed
5 of 9 tasks

[Bug]: Don't cache quota when queried in web UI #35421

PVince81 opened this issue Nov 25, 2022 · 2 comments

Comments

@PVince81
Copy link
Member

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Quota in web UI only updates after a delay.

From my understanding the purpose of the quota cache is only to save performance with repeated PROPFINDs, not when queried for display.

  • idea 1: only use the cached quota value for PROPFINDs
  • idea 2: invalidate the quota cache as soon as size propagation happens (ex: through upload operations)

Steps to reproduce

  1. Setup a user with a quota of 5 GB
  2. Login as that user
  3. Upload a bunch of files
  4. Refresh the page
  5. Look at the used space at the bottom left

Expected behavior

Used space must adjust itself immediately.

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

N/A

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

Observed on master and stable25, pre 25.0.2 RC1

@PVince81 PVince81 added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 25, 2022
@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of performance 🚀 24-feedback and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 25, 2022
@PVince81 PVince81 added this to the Nextcloud 25.0.3 milestone Nov 25, 2022
@eltos
Copy link

eltos commented Jan 15, 2023

The quota cache must also be invalidated immediately if the default or per-user limit is changed via the users page in the admin web interface (nextcloud.example.com/settings/users).
Currently, it just makes you think that the change in quota limit was not applied, especially since reloading the page will show the old value again (and there is no hint explaining that it just takes a few minutes).

EDIT: Related issue: #34422:

#34422 (comment):
The problem of changed quota's not being seen for a while is because in the public static function getStorageInfo there is a caching call to "ICacheFactory".. when I turn that off, That problem is gone.. is there something not being updated to that cache when the quota is changed?

#34422 (comment):
If memory serves me well,, I do think that the wrong/old setting is indeed gone after say 5 minutes.
But that does keep the question valid, why isn't the cache updated upon altering the quota?

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2024

We update it now based on upload or other events (28+)

@skjnldsv skjnldsv closed this as completed Aug 1, 2024
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📁 Files team Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

No branches or pull requests

7 participants