Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NC 25 Dark Theme default avatar not showing under Contacts Menu #34503

Closed
7 of 9 tasks
AndyXheli opened this issue Oct 10, 2022 · 5 comments
Closed
7 of 9 tasks
Assignees

Comments

@AndyXheli
Copy link

AndyXheli commented Oct 10, 2022

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Currently on NC 25 the new avatar was introduced https://github.com/nextcloud/server/pull/33752/files. Since this was introduced the Contact Menu is only displaying avatars in white when server theme is set to dark mode

image

Current code to load picture would be in here. Do you have any recommendations for me? So I can create a pull request and do some testing for you guys ?

https://github.com/nextcloud/server/blob/master/lib/private/Contacts/ContactsMenu/ContactsStore.php

Steps to reproduce

Open Contact Menue

Expected behavior

Should show in dark mode avatar when server them is set to dark

Installation method

Community Manual installation with Archive

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

NA

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@AndyXheli AndyXheli added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Oct 10, 2022
@PVince81
Copy link
Member

slightly related but this was only icons, not avatars: #34571

@AndyXheli

This comment was marked as outdated.

@AndyXheli AndyXheli changed the title [Bug]: NC 25 Dark Theme default avatar now showing under Contacts Menu [Bug]: NC 25 Dark Theme default avatar not showing under Contacts Menu Mar 29, 2023
@AndyXheli
Copy link
Author

Still an issue on NC 27 @szaimen can we please remove NC 25 feedback and put NC 27 ?

@AndyXheli
Copy link
Author

Looks like this issue has been fixed in NC 28 RC 4 but still an issue on NC 27.1.5

@joshtrichards
Copy link
Member

Agreed. Confirmed fixed in >=28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants