Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording for unsharing incoming share #18622

Closed
wiswedel opened this issue Jan 2, 2020 · 5 comments · Fixed by #22376
Closed

Wording for unsharing incoming share #18622

wiswedel opened this issue Jan 2, 2020 · 5 comments · Fixed by #22376
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: accessibility feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone

Comments

@wiswedel
Copy link
Contributor

wiswedel commented Jan 2, 2020

Calendar 2.0 (NC 18+) uses the wording "Unshare from me" for opting out of incoming shares.

image

I like that clarification that points out the difference between being the share owner and being the sharee, so I suggest to have that wording in Files as well.

Should this request get rejected, the issue needs to addressed as a UX streamlining issue at https://github.com/nextcloud/calendar/.

@wiswedel wiswedel added enhancement design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: sharing 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: accessibility labels Jan 2, 2020
@wiswedel
Copy link
Contributor Author

wiswedel commented Jan 2, 2020

CC @nextcloud/designers

@jancborchardt
Copy link
Member

We never use "me" or "my" so the wording is definitely nonstandard. It could be "Unshare from self" but that’s a bit odd.

I think it’s enough to have the 2 distinct actions:

  • If you are the owner: You manage shares via "Share", and the destructive action is "Delete" with an icon-delete trashbin.
  • If you are recipient: The destructive action is "Unshare" with an icon-close X.

So I’d say Calendar should adjust to use Unshare with an icon-close X. cc @georgehrke

@wiswedel
Copy link
Contributor Author

wiswedel commented Jan 2, 2020

We never use "me" or "my"

What about this then?
image

@jancborchardt
Copy link
Member

@wiswedel that’s "you", which we do use as it’s conversational. :) But we never use "me", which is basically personifying the software.

So we could write "Unshare from you". We should adjust it in Calendar @georgehrke, and then also use that in Files.

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 13, 2020
jancborchardt added a commit that referenced this issue Aug 23, 2020
@jancborchardt
Copy link
Member

Pull request to fix this at #22376

@jancborchardt jancborchardt added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Aug 23, 2020
@jancborchardt jancborchardt added this to the Nextcloud 20 milestone Aug 23, 2020
kesselb pushed a commit that referenced this issue Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: accessibility feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants