Bugs/features after the new sidebar

[skjnldsv]

After #15719

parity

• Use new sidebar api to register groupfolders section groupfolders#507
• Comply to 18 new sharing ui socialsharing#37
• Update app to fit 18 new Sharing sidebar guests#153
• Sidebar preview plugins (e.g. from files_pdfviewer) are no longer working

cleanup

• Old templates and scripts from core Cleanup sharing leftovers #17753
• Migrate scripts loading to the new LoadSidebar event Migrate tabs scripts to LoadSidebar event #17751
• Use OCA.Files.Sidebar.open(path) instead of file setter Use function to open a sidebar file #17750
• Fix files_sharing app LoadSidebar event Fix files_sharing app LoadSidebar event #17821
• Fix files_versions app LoadSidebar event Fix files_versions app LoadSidebar event #17829
• Fix comments app init and LoadSidebar event Fix comments app init and LoadSidebar event #17803

bugs

• Cannot open the sidebar from the share icon breadcrumbs
• The tags should not me shown if none are set, we should add that to the actions menu on the sidebar
• Differentiate focus and focus-keyboard on actions nextcloud-libraries/nextcloud-vue#704
• The currently selected file is not highlighted in the file list anymore

[juliusknorr]

Added:

• The currently selected file is not highlighted in the file list anymore
• Sidebar preview plugins (e.g. from files_pdfviewer) are no longer working

[skjnldsv]

• Sidebar preview plugins (e.g. from files_pdfviewer) are no longer working

this is done on purpose.
they should comply to proper preview generator :)

Because loading big files directly is not something we want (txt, pdf...)
It's too heavy (and probably not ok security wise)!

[juliusknorr]

I think that is a regression that people will complain about a lot. I also fear that there is no real way to have a proper preview of markdown documents generated as an image with just PHP and we should have nice previews for documents of the text app for example.

[juliusknorr]

Also plaintext previews look really bad imo:

[skjnldsv]

Pdf can be rendered with imagick.
This is the same as videos. We could inject lots of scripts into the sidebar to fake a real preview, but it's:

1. heavy to load the script
2. heavy to load the file
3. complexify the whole thing a lot and is much sloppier
4. can lead to security issues if we load a file that contains a security hack or something (pdf xss...)

[szaimen]

Pdf can be rendered with imagick. This is the same as videos.

Aren't there problems with imagick?
#13099

Apart from that, I agree with @skjnldsv.

[wiswedel]

Cannot open the sidebar from the share icon breadcrumbs

This is checked as resolved, but still happens in beta2 - has the fix been merged just too recently or is something still wrong?

[skjnldsv]

This is checked as resolved, but still happens in beta2 - has the fix been merged just too recently or is something still wrong?

fix was merged but another pr broke it.
#18425

[jancborchardt]

What about the The tags should not me shown if none are set, it seems to be blocked by "differentiate focus and focus-keyboard on actions" nextcloud-libraries/nextcloud-vue#704

Now that @jospoortvliet is taking screenshots, the "Collaborative tags" box is in all the screenshots and it doesn’t look good. cc @skjnldsv :)

[skjnldsv]

What about the The tags should not me shown if none are set, it seems to be blocked by "differentiate focus and focus-keyboard on actions" nextcloud/nextcloud-vue#704

No it's just a matter of adding a toggle for it :(
No time yet

[juliusknorr]

The tags should not me shown if none are set, we should add that to the actions menu on the sidebar

Already fixed by #18732

[juliusknorr]

Closing since all server related ones are fixed and only nextcloud-libraries/nextcloud-vue#704 is remaining to be fixed in the components.