Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO (rocketchat) required to grant access to their Nextcloud account on each login #12377

Closed
mbh-dev opened this issue Nov 9, 2018 · 23 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info

Comments

@mbh-dev
Copy link

mbh-dev commented Nov 9, 2018

Steps to reproduce

  1. Login to Rocket Chat via Nextcloud using OAuth
  2. Grant Access
  3. Logout of Rocket Chat
  4. Have to regrant access on logging into Rocket Chat via Nextcloud OAuth

Expected behaviour

User should only be required to grant access to their Nextcloud account once

Actual behaviour

Each time a user logs into Rocket chat they are required to grant access to their Nextcloud account each time

Server configuration

Operating system: Ubuntu 18.04

Web server: Apache

Database: MySql

PHP version: 7.2

Nextcloud version: (see Nextcloud admin page) 14.0.0

Updated from an older Nextcloud/ownCloud or fresh install: Updated

Where did you install Nextcloud from: Source

Login as admin user into your Nextcloud and access 
No Errors have been found

Operating system:** Windows 10

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #8330 (Nextcloud Documentation Issue), #9023 (Connect Rocket.Chat with Nextcloud in order to build a strong communication platform), #6718 (Nextcloud 12 Upgrade and Collation Issues), #10941 (Nextcloud customiztion), and #11202 (Nextcloud 14 Upgrade issue. ).

@Elfanar
Copy link

Elfanar commented Jan 30, 2019

No information how to authenticate nextcloud users on rocket chat seamlessly ?

@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019
@cjhille
Copy link

cjhille commented Feb 10, 2020

Seeing the same issue. Nextcloud creates a new "app-password" for every login.

@skjnldsv
Copy link
Member

@ChristophWurst @rullzer for app token

@skjnldsv skjnldsv changed the title Nextcloud and Rocket Chat Integration Issues Sso (rocketchat) required to grant access to their Nextcloud account on each login Apr 10, 2020
@skjnldsv skjnldsv changed the title Sso (rocketchat) required to grant access to their Nextcloud account on each login SSO (rocketchat) required to grant access to their Nextcloud account on each login Apr 10, 2020
@ghost
Copy link

ghost commented May 10, 2020

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label May 10, 2020
@cjhille
Copy link

cjhille commented May 10, 2020

Since #13182 was closed, it would be awesome if this remained open.

@ghost ghost removed the stale Ticket or PR with no recent activity label May 10, 2020
@ghost
Copy link

ghost commented Jun 9, 2020

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Jun 9, 2020
@cjhille
Copy link

cjhille commented Jun 9, 2020

AFAIK still an issue with Nextcloud 19.

@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 9, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Jul 9, 2020
@rullzer
Copy link
Member

rullzer commented Jul 9, 2020

So this then most likely is an issue in rocket chat not reusing the token... other oauth providers work just fine. Let me close this unless somebody can provide more info.

@rullzer rullzer closed this as completed Jul 9, 2020
@derspotter
Copy link

The issue still persists...

@AlfredoCubitos
Copy link

I can confirm that this issue still exists.
I have a plain clear installation, nothing special. Only few users.
This error is very annoying!
I do not understand why for every login session with the same login name a new entry is created instead of updating the existing session entries?
Please reopen this bug and fix it.

@ghost ghost removed the stale Ticket or PR with no recent activity label Sep 15, 2021
@ChristophWurst
Copy link
Member

I'm happy to reopen. But Nextcloud is a community project.

reopen this bug and fix it

We're happy to help you with your fixes and getting them merged. Please feel free to dig into the code and fix the issue yourself if you can or hire someone who can do this for you ✌️

@AlfredoCubitos
Copy link

I have made some tests, and I came to the conclusion that this may not really a server problem, but rather a desktop/mobile client problem.
@ChristophWurst : do you know if the cron.php cleans up also the oc_authtoken table?
If this is so, this could also be cronjob problem.

@ChristophWurst
Copy link
Member

Yes, \OC\Authentication\Token\DefaultTokenCleanupJob takes care of old session tokens.

@AlfredoCubitos
Copy link

Ok, it seems that the cronjob does not work correctly.
I made several changes to cronjob option but always I get an error message like this Some jobs didn’t execute since x days ago.
So I called cron.php manually and it returns success but the old sessions in the oc_authtoken were not deleted.

Know I am at the end with my wisdom. I do not know where to look for the error.
@ChristophWurst : do you have any idea?

@ChristophWurst
Copy link
Member

Let's put the cron problem/questions on https://help.nextcloud.com ;)

@AlfredoCubitos
Copy link

@ChristophWurst I think you can close this issue here.
I found out that entries with set remember = 1 are expiring after 15 days, this may lead to huge entries in oc_authtoken on sites with heavy traffic.

Do you know where this attribute remember=1 is set and why?

@ghost
Copy link

ghost commented Nov 1, 2021

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Nov 1, 2021
@ChristophWurst
Copy link
Member

Do you know where this attribute remember=1 is set and why?

At \OC\Authentication\Login\CreateSessionTokenCommand::process

@ghost ghost removed the stale Ticket or PR with no recent activity label Nov 2, 2021
@ghost
Copy link

ghost commented Dec 2, 2021

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Dec 2, 2021
@ghost ghost closed this as completed Dec 16, 2021
@cjhille
Copy link

cjhille commented Dec 16, 2021

noooooooo @nextcloud-bot bad bot ... still an issue :/

@ghost ghost removed the stale Ticket or PR with no recent activity label Dec 16, 2021
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of stale Ticket or PR with no recent activity and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 16, 2021
@ghost ghost removed the stale Ticket or PR with no recent activity label Dec 16, 2021
@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

@szaimen szaimen added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2023
@szaimen szaimen closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info
Projects
None yet
Development

No branches or pull requests

10 participants