Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn/check if any 2FA provider is active before enforcing 2FA #12267

Open
ChristophWurst opened this issue Nov 5, 2018 · 3 comments
Open

Warn/check if any 2FA provider is active before enforcing 2FA #12267

ChristophWurst opened this issue Nov 5, 2018 · 3 comments
Labels

Comments

@ChristophWurst
Copy link
Member

From #12249

Another thing which confuses me is that I can enforce two factor auth even if no single two factor out method is enabled. I think it would make sense to check that at least one is enabled (u2f, totp,...) and otherwise disable the checkbox.

@rummatee
Copy link
Contributor

I implemented this feature, but I noticed, that there is one 2FA provider that is always enabled: backup_codes. I'm not completely sure how this should be dealt with. Should enforcing 2FA only be possible with at least 2 providers, or should just any provider called 'backup_codes' be ignored, when deciding if enforcing should be allowed?

@ChristophWurst
Copy link
Member Author

Yep, that is what I also did at

$providerIdsWithoutBackupCodes = array_diff($providerIds, [self::BACKUP_CODES_PROVIDER_ID]);
. This one is a special provider and it's fine to have an exception for it.

@szaimen
Copy link
Contributor

szaimen commented May 20, 2021

It seems like this is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants