Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User avatar generator issues with font #12058

Closed
jancborchardt opened this issue Oct 25, 2018 · 13 comments
Closed

User avatar generator issues with font #12058

jancborchardt opened this issue Oct 25, 2018 · 13 comments
Assignees
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: users and groups papercut Annoying recurring issue with possibly simple fix.
Milestone

Comments

@jancborchardt
Copy link
Member

For the Mail app and the Contacts menu, the generated avatars look great:
Generated avatars in Mail app Generated avatars in Contacts menu

Now compare it to the user management and the Files app (here the sharing view).
The typeface is wrong, there are even completely varying thicknesses. Is this a caching issue?
users avatar generator wrong
font for avatars wrong

cc @nextcloud/designers

@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of papercut Annoying recurring issue with possibly simple fix. feature: users and groups labels Oct 25, 2018
@jancborchardt jancborchardt added this to the Nextcloud 15 milestone Oct 25, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10248 (Introduces avatars for guest users), #8635 (OCP\Files\NotFoundException related to user's avatar), #7444 (Quota 0 issues: Avatar and AudioPlayer scan), #11923 (Users layout), and #3482 (Issue with documents).

@skjnldsv
Copy link
Member

@jancborchardt have you enabled imagick?

@MorrisJobke
Copy link
Member

@jancborchardt have you enabled imagick?

Could we add some checks to the admin page about this. Just to make it easier for admins to spot ;)

@rullzer
Copy link
Member

rullzer commented Oct 26, 2018

@jancborchardt did you generate some users before the switch of font and some after?

We generate the image of the avatar server side. So that all the clients can always obtain an image.

@jancborchardt
Copy link
Member Author

@rullzer all users were created before the font switch.

Just created a new one (2nd entry in screenshot) but the font is still wrong:
screenshot from 2018-10-30 00-17-26

@jancborchardt have you enabled imagick?

@skjnldsv not sure, how do I check? But really since it works for the Mail app and the Contacts menu, shouldn’t it work in Files and Users too?

@skjnldsv
Copy link
Member

skjnldsv commented Oct 30, 2018

@jancborchardt it depends on the source of the avatars.

  1. are those images or javascript generated?
  2. we generate multiple avatar sizes when requested, so if we requested the 44px before the font update, and then you load the mail app that request 32px after the fonts change, it will be different
  3. The avatar are generated with the gd library (php) which is an impossible way to work with. For cleaner avatars you need imagick. You can check with a php file and phpinfo to check if you have it
    Create a phpinfo.php file at the root of your nextcloud, edit it and put inside
    <?php
     phpinfo();
    
    Then go to your cloud.com/phpinfo.php and see if you have imagick

Nonetheless, you can also delete the avatar cache and scan the app-data folder with occ to reset everything :)
@rullzer we should probably create a command for that? Or add it into the repair one?

@MorrisJobke
Copy link
Member

@rullzer we should probably create a command for that? Or add it into the repair one?

👍

We also should do step 3 automatically and add it to the setup warnings page. 😉

@rullzer
Copy link
Member

rullzer commented Oct 30, 2018

Of course we should only kill generated avatars ;) Not all avatars.

@jancborchardt
Copy link
Member Author

Whatever we do, let’s make it so that it automatically fixes the avatars for everyone upgrading to Nextcloud 15, does that work? Cause people shouldn’t need to check the setup page and run a command to fix typography in the avatars. 😉

@rullzer
Copy link
Member

rullzer commented Oct 30, 2018

@jancborchardt it is not about NC15 it is about if you have imagemagic or not

@jancborchardt
Copy link
Member Author

Aaah ok – so what you are saying is:

  • We need ImageMagick cause we need to give the avatar pngs to our apps/clients too
  • Contacts and Mail don’t use ImageMagick, because they don’t need to give their avatars to any clients
  • I don’t have ImageMagick installed so the avatars generated by Contacts and Mail will always look great cause they are HTML+CSS and use the font, while the ones from user management will always look bad cause I don’t have ImageMagick and thus it doesn’t load the Nunito font?

Is that correct? :D

@skjnldsv
Copy link
Member

yes basically :)
But you don't need imagick, the gd library will also work, we cannot afford to NOT have generated avatars. But they look less nice :)

You don't need imagick, but it's highly recommended if you want nice avatars :)
See #9197

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Nov 6, 2018
@skjnldsv skjnldsv self-assigned this Nov 6, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Nov 6, 2018

fix in #12313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: users and groups papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

5 participants