Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload of files with comma does not work (TypeError: xml is undefined) #12002

Closed
sedrubal opened this issue Oct 23, 2018 · 6 comments
Closed
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: files

Comments

@sedrubal
Copy link

Steps to reproduce

  1. on local machine: touch 'foo,bar'
  2. Upload the file via the web interface (drag and drop or by via the file dialog)

Expected behaviour

The file should be uploaded as every other file.

Actual behaviour

After uploading the file, it does not appear in the web interface and the progress bar stops and does not disappear. Instead you can see this error message in the browser console (on Chromium):

merged-index.js?v=4e579112-8:1366 Uncaught TypeError: Cannot read property 'message' of undefined
    at HTMLInputElement.fail (merged-index.js?v=4e579112-8:1366)
    at e.(/cloud/apps/files/anonymous function).(anonymous function)._trigger (https://xxx/cloud/core/vendor/core.js?v=4e579112-8:13:10075)
    at e.(/cloud/apps/files/anonymous function).(anonymous function)._onFail (https://xxx/cloud/js/files/merged-index.js?v=4e579112-8:2764:18)
    at e.(/cloud/apps/files/anonymous function).(anonymous function)._onFail (https://xxx/cloud/core/vendor/core.js?v=4e579112-8:13:5077)
    at Object.<anonymous> (merged-index.js?v=4e579112-8:2798)
    at j (core.js?v=4e579112-8:2)
    at Object.fireWith [as rejectWith] (core.js?v=4e579112-8:2)
    at x (core.js?v=4e579112-8:4)
    at XMLHttpRequest.<anonymous> (core.js?v=4e579112-8:4)

Server configuration

Operating system: CentOS Linux release 7.5.1804

Web server: nginx & ???

Database: 10.3.10-MariaDB

PHP version: PHP 7.2.11

Nextcloud version: (see Nextcloud admin page) 14.0.3

Updated from an older Nextcloud/ownCloud or fresh install: 1 times upgraded from 14.0.?

Where did you install Nextcloud from: WebInstaller

Signing status:

Signing status
No errors have been found.

List of activated apps:

App list
Enabled:
  - accessibility: 1.0.1
  - activity: 2.7.0
  - bruteforcesettings: 1.1.0
  - cloud_federation_api: 0.0.1
  - comments: 1.4.0
  - dav: 1.6.0
  - federatedfilesharing: 1.4.0
  - federation: 1.4.0
  - files: 1.9.0
  - files_pdfviewer: 1.3.2
  - files_sharing: 1.6.2
  - files_texteditor: 2.6.0
  - files_trashbin: 1.4.1
  - files_versions: 1.7.1
  - files_videoplayer: 1.3.0
  - firstrunwizard: 2.3.0
  - gallery: 18.1.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.2.0
  - nextcloud_announcements: 1.3.0
  - notifications: 2.2.1
  - oauth2: 1.2.1
  - password_policy: 1.4.0
  - provisioning_api: 1.4.0
  - serverinfo: 1.4.0
  - systemtags: 1.4.0
  - theming: 1.5.0
  - twofactor_backupcodes: 1.3.1
  - updatenotification: 1.4.1
  - workflowengine: 1.4.0
Disabled:
  - admin_audit
  - encryption
  - files_external
  - sharebymail
  - support
  - survey_client
  - user_external
  - user_ldap

Nextcloud configuration:

Config report
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/xxx\/cloud",
        "htaccess.RewriteBase": "\/cloud",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "auth.bruteforce.protection.enabled": true,
        "trusted_domains": [
            "xxx"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "14.0.3.0",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_smtpmode": "sendmail",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "maintenance": false,
        "loglevel": 2
    }
}

Are you using external storage, if yes which one: local

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 62.0.3 / Chromium 69.0.3497.100

Operating system: Fedora 29 (also happens with other browsers on Windows)

Logs

Web server error log

Web server error log
-

Nextcloud log (data/nextcloud.log)

Nextcloud log
-

Browser log

Browser log
querying Whats New data was successful: nocontent merged-template-prepend.js:4480:4
undefined merged-template-prepend.js:4481:4
GET https://xxx/cloud/svg/core/actions/add/000?v=1 [HTTP/2.0 200 OK 84ms]
GET https://xxx/cloud/apps/theming/img/core/filetypes/folder.svg?v=8 [HTTP/2.0 200 OK 61ms]
GET https://xxx/cloud/svg/core/actions/upload/000?v=1 [HTTP/2.0 200 OK 60ms]
GET https://xxx/cloud/apps/theming/img/core/filetypes/text.svg?v=8 [HTTP/2.0 200 OK 82ms]
GET https://xxx/cloud/svg/core/actions/close/000?v=1 [HTTP/2.0 200 OK 79ms]
TypeError: xml is undefined
(see above)
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #3996 (File names with colons), #3488 (File Upload works but can't upload folder), #1371 (No file-uploading possible at all), #3147 (updater does not work on FreeBSD), and #11366 (Upload of folders in IE via web does not work anymore).

@violoncelloCH
Copy link
Member

@sedrubal have you tried uploading such a file via sync client?

@sedrubal
Copy link
Author

Now I tried and as soon as I create a file containing a comma, the file won't be synchronized and I see the error message:

... Server replied: Method Not Allowed

I also tried to create a file using the + Button and "New text file" and it does not work neither (but I can't see any errors in the javascript console).

Maybe I messed something up during installation. Do you have an idea what the "Method" is, that is not allowed?

I tested it with an other nextcloud instance and there everything is working.

@violoncelloCH
Copy link
Member

Could you try if the logs tell more with activated debug mode (in config.php)? Please also check the nextcloud log.

@sedrubal
Copy link
Author

The nextcloud log remains empty even on log level 0.

I found out, that the browser tries to make a PUT request to the following URL and receives a 405 Method not allowed:

https://xxx/cloud/remote.php/dav/files/username/foo%2Cbar.txt

I assume there is an issue with the webserver config (which I can't edit, because it is hosted on a shared host).

But however nextcloud should show a meaningful error message and not fail silently with messages in the browser console, that don't tell you anything about the problem...

@sedrubal sedrubal changed the title Upload of files with colon does not work (TypeError: xml is undefined) Upload of files with comma does not work (TypeError: xml is undefined) Oct 27, 2018
@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019
@skjnldsv
Copy link
Member

As the version of the software you've reported this for has reached end of life, I will close this ticket. If this is still happening after an upgrade to the latest version, feel free to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: files
Projects
None yet
Development

No branches or pull requests

4 participants