Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NC 14] Sidebar close icon; incompatible 'position: sticky' in Safari #10745

Closed
Rello opened this issue Aug 18, 2018 · 2 comments · Fixed by #10747
Closed

[NC 14] Sidebar close icon; incompatible 'position: sticky' in Safari #10745

Rello opened this issue Aug 18, 2018 · 2 comments · Fixed by #10747
Assignees
Labels
bug design Design, UI, UX, etc. regression
Milestone

Comments

@Rello
Copy link
Contributor

Rello commented Aug 18, 2018

Steps to reproduce

  1. the sidebar close icon is "missing" when using Safari
    screen shot 2018-08-18 at 22 35 30

  2. Inspector shows in behind the header

  3. chrome seems to be fine

Expected behaviour

back to normal

Actual behaviour

wrong

Server configuration

Nextcloud version: NC14 Beta 4

Client configuration

Browser: Safari 11.1

Operating system: macOS

Reason:

the app-sidebar css was changed from position: fixed; to position: sticky;
https://github.com/nextcloud/server/blob/master/core/css/apps.scss#L642

This is not compatible with Safari
https://caniuse.com/#search=sticky

it would be by using position: -webkit-sticky; but this will not work on e.g. chrome.

@nextcloud-bot nextcloud-bot added bug design Design, UI, UX, etc. labels Aug 18, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #6041 (Compact sidebar - icon only sidebar), #10603 (Ideas for NC 14), #10372 (Fix files header sticky positioning ), #7724 (The loading icon is not at the same position as the checkbox it replaces), and #5157 (Icon inconsistency).

@weeman1337 weeman1337 self-assigned this Aug 19, 2018
@weeman1337
Copy link
Member

@Rello thanks for the report.

it would be by using position: -webkit-sticky; but this will not work on e.g. chrome.

It is possible to have more than one position rule. The first one recognized by the browser is taken. So it's not a problem to have

position: -webkit-sticky;
position: sticky;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Design, UI, UX, etc. regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants