Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppNavigationSettings automatically close on "click outside" #862

Closed
nickvergessen opened this issue Feb 19, 2020 · 8 comments · Fixed by #983
Closed

AppNavigationSettings automatically close on "click outside" #862

nickvergessen opened this issue Feb 19, 2020 · 8 comments · Fixed by #983
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: app-navigation Related to the app-navigation component

Comments

@nickvergessen
Copy link
Contributor

In Talk we use the app navigation setting to selec tthe attachment folder.
Unluckily clicking anything in the filepicker will close the settings menu.
This feels very weird and we need a way to prevent this.

Peek 2020-02-19 13-50

@nickvergessen nickvergessen added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: app-navigation Related to the app-navigation component labels Feb 19, 2020
@skjnldsv
Copy link
Contributor

Yep, hard to manage :/
Anyone have an idea for a fix?

@georgehrke
Copy link
Contributor

Related to #834

@georgehrke
Copy link
Contributor

georgehrke commented Feb 27, 2020

I see two options here:

  1. Either AppNavigationSettings should expose open a property #834 and watch for changes of open, if it changes change it back to keep it open (feels a little hacky)
  2. Allow to override the v-click-outside handler (something we do nowhere else)
  3. Have auto-close as prop

@georgehrke
Copy link
Contributor

@skjnldsv @nickvergessen Any preference on a solution? :)

@nickvergessen
Copy link
Contributor Author

Not my level of expertise

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 2, 2020

  • Allow to override the v-click-outside handler (something we do nowhere else)

I would maybe go for something like this.
I faced the same issue recently. v-click-outside allows to register a middleware, which we can fit to have specific exclude rules

My take would be either a class or a data-exclude-click-outside or something. SO we can have a target and define areas that will be excluded. Of course I would let the dev implement the target, but for the example of the modal, we could pass an id to the modal and pass it as a prop to the settings to make sure this si excluded from outside?

@georgehrke georgehrke self-assigned this Apr 2, 2020
@georgehrke
Copy link
Contributor

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 2, 2020

I don't know, can you give an example of code on the pr? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants