Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in item content not clickablee #2940

Closed
3 tasks done
tyrylu opened this issue Nov 26, 2024 · 8 comments · Fixed by #2946 or #2950
Closed
3 tasks done

Links in item content not clickablee #2940

tyrylu opened this issue Nov 26, 2024 · 8 comments · Fixed by #2946 or #2950
Labels
bug frontend impact Javascript/Frontend code

Comments

@tyrylu
Copy link

tyrylu commented Nov 26, 2024

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

When an item has links in the displayed content (the comments link in a Hackernews post, for example), they are definitely not clickable with Orca, but very likely are not links in the DOM either.

Steps to Reproduce

  1. Have a news item with links in its output, and have it displayed
  2. Observe that you can not activate the link with Orca and with another screen readers as well

System Information

  • News app version: 5.0.2
  • Nextcloud version: 30.0.2
  • Cron type: Not relevant
  • PHP version: Not relevant
  • Database and version: Not relevant
  • Browser and version: Everything i tested - Firefox 132.0.2, Chromium 131.0.6778.85
  • OS and version: Latest Arch linux, but would likely be everywhere

No errors in any logs.

@tyrylu tyrylu added the bug label Nov 26, 2024
@Grotax Grotax added the frontend impact Javascript/Frontend code label Nov 27, 2024
@wofferl
Copy link
Collaborator

wofferl commented Nov 27, 2024

For the links issue, I was referring to the text under the h1 of an article, if there's something (e. g. the intro-container div). You definitely can not get to a link in this text using the tab key, you can do that using up and down arrows, but the text definitely does not have the original link. And, is the hiding of the two buttons except for the share one using aria-hidden (and having them no labels either) intentional, by the way?

I think the text in the intro-container has no links in it, but I need to verify. The structure since news 24 has changed because of the rewrite, the scrollable list only contains the info and the article is displayed separately at an extra pane right (default) or below (expanded compact view). In compact view the article is displayed as whole when you select an item. This things are discussed in #2919.

For the buttons I already added a fix which will be in the next version: #2934

@tyrylu
Copy link
Author

tyrylu commented Nov 27, 2024

Well, if there's an additional pane, I newer saw it anywhere with the screen reader... And, thanks for the buttons.

@wofferl
Copy link
Collaborator

wofferl commented Nov 28, 2024

Well, if there's an additional pane, I newer saw it anywhere with the screen reader... And, thanks for the buttons.

I added landmarks so that the screen reader can recognize it.

@tyrylu
Copy link
Author

tyrylu commented Nov 28, 2024

Not sure whether it will be enough (I am afraid that the pane did not show at all - maybe for the same reason scrolling is broken, but that is only a wild guess), linkifiing the intro would be nice as well.

@wofferl
Copy link
Collaborator

wofferl commented Nov 28, 2024

With the changes I made for the next version the panes are show in the landmark list and I can select the item with enter after using the heading navigation and than switch with the orca shortcut m to the details pane or with the news app shortcut o open the original article in a new tab.

The links in the intro you referring to are links to the original article or others of interest?

@tyrylu
Copy link
Author

tyrylu commented Nov 29, 2024

To whatever the RSS author put it there, for example, the Hacker news feed puts the link to the comments of the post in it, and it was quite handy to be able to go just by one down arrow and open that. Also, for some long intros (for example https://devblogs.microsoft.com/oldnewthing/feed/), having the intro without any filtering in a span looks weird at least for a screen reader, but I'd wager that the visuals are not nice either.

@wofferl
Copy link
Collaborator

wofferl commented Nov 30, 2024

I now have implented an extra mode which should work as the non-compact mode in news 24.

@wofferl wofferl reopened this Nov 30, 2024
@tyrylu
Copy link
Author

tyrylu commented Nov 30, 2024

Thanks very much for that, I appreciate you actually caring about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug frontend impact Javascript/Frontend code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants