-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links in item content not clickablee #2940
Comments
I think the text in the intro-container has no links in it, but I need to verify. The structure since news 24 has changed because of the rewrite, the scrollable list only contains the info and the article is displayed separately at an extra pane right (default) or below (expanded compact view). In compact view the article is displayed as whole when you select an item. This things are discussed in #2919. For the buttons I already added a fix which will be in the next version: #2934 |
Well, if there's an additional pane, I newer saw it anywhere with the screen reader... And, thanks for the buttons. |
I added landmarks so that the screen reader can recognize it. |
Not sure whether it will be enough (I am afraid that the pane did not show at all - maybe for the same reason scrolling is broken, but that is only a wild guess), linkifiing the intro would be nice as well. |
With the changes I made for the next version the panes are show in the landmark list and I can select the item with enter after using the heading navigation and than switch with the orca shortcut m to the details pane or with the news app shortcut o open the original article in a new tab. The links in the intro you referring to are links to the original article or others of interest? |
To whatever the RSS author put it there, for example, the Hacker news feed puts the link to the comments of the post in it, and it was quite handy to be able to go just by one down arrow and open that. Also, for some long intros (for example https://devblogs.microsoft.com/oldnewthing/feed/), having the intro without any filtering in a span looks weird at least for a screen reader, but I'd wager that the visuals are not nice either. |
I now have implented an extra mode which should work as the non-compact mode in news 24. |
Thanks very much for that, I appreciate you actually caring about this. |
IMPORTANT
Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)
Explain the Problem
When an item has links in the displayed content (the comments link in a Hackernews post, for example), they are definitely not clickable with Orca, but very likely are not links in the DOM either.
Steps to Reproduce
System Information
No errors in any logs.
The text was updated successfully, but these errors were encountered: