Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: important database changes that require a cache reset #4735

Closed
2 tasks done
ChristophWurst opened this issue Mar 11, 2021 · 4 comments
Closed
2 tasks done

Meta: important database changes that require a cache reset #4735

ChristophWurst opened this issue Mar 11, 2021 · 4 comments

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 11, 2021

We currently have a few optimizations and changes that are potentially problematic to apply on a production instance because adding columns and indices to large tables is slow and web updates could therefore run into a timeout. This is a meta ticket to track all of those changes so we can do them in one go, to avoid resetting the cache too often.

A prerequisite for the cache reset is that we lose as little data as important.

  • Store new flag_important always on IMAP if the server supports it
  • Possibly use new tagging feature/table Add tagging to messages #4665 to restore importance and other flags for servers that don't allow arbitrary tags/flags
@ChristophWurst
Copy link
Member Author

#4665 is scheduled for v1.10. I think it might be best to push that out, ensure that data is put into a more reliable spot (IMAP and the tags table) and then in a v1.11 we can do the big changes.

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 17, 2021

We found out that junk has three states: not classified, junk and not junk. We should therefore improve our messages table and add a flag_not_junk column for $notjunk. see #4662

@ChristophWurst
Copy link
Member Author

@miaulalala let's revisit this soon because I think the two todo items are actually done :)

@ChristophWurst
Copy link
Member Author

A prerequisite for the cache reset is that we lose as little data as important

@miaulalala we can tick those two items now, can't we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants