Update app to fit 18 new Sharing sidebar (#153)

Update app to fit 18 new Sharing sidebar

.drone.yml

@@ -26,15 +26,15 @@ trigger:
     - pull_request
     - push
 ---
-
 kind: pipeline
-name: frontend
+name: webpack-build
+
 steps:
-  - name: jsbuild
-    image: nextcloudci/node:node-4
-    commands:
-      - apk add --no-cache make
-      - make
+- name: build
+  image: nextcloudci/node:node-4
+  commands:
+    - npm ci
+    - npm run build
 
 trigger:
   branch:

.eslintrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+	extends: [
+		'nextcloud'
+	]
+}

.gitignore

@@ -5,4 +5,4 @@ build/
 vendor/
 clover.xml
 js
-
+.vscode

.stylelintrc.js

@@ -0,0 +1,32 @@
+module.exports = {
+	extends: 'stylelint-config-recommended-scss',
+	rules: {
+		indentation: 'tab',
+		'selector-type-no-unknown': null,
+		'number-leading-zero': null,
+		'rule-empty-line-before': [
+			'always',
+			{
+				ignore: ['after-comment', 'inside-block']
+			}
+		],
+		'declaration-empty-line-before': [
+			'never',
+			{
+				ignore: ['after-declaration']
+			}
+		],
+		'comment-empty-line-before': null,
+		'selector-type-case': null,
+		'selector-list-comma-newline-after': null,
+		'no-descending-specificity': null,
+		'string-quotes': 'single',
+		'selector-pseudo-element-no-unknown': [
+			true,
+			{
+				ignorePseudoElements: ['v-deep']
+			}
+		]
+	},
+	plugins: ['stylelint-scss']
+};

Makefile

@@ -37,6 +37,19 @@ clean:
 clean-dev:
 	rm -rf node_modules
 
+# Linting
+lint:
+	npm run lint
+
+lint-fix:
+	npm run lint:fix
+
+# Style linting
+stylelint:
+	npm run stylelint
+
+stylelint-fix:
+	npm run stylelint:fix
 
 appstore: clean package
 

appinfo/info.xml

@@ -9,7 +9,7 @@
 Guests accounts can be created from the share menu by entering either the recipients email or name and choosing "create guest account", once the share is created the guest user will receive an email notification about the mail with a link to set their password.
 
 Guests users can only access files shared to them and can't create any files outside of shares, additionally, the apps accessible to guest accounts are whitelisted.]]></description>
-	<version>1.3.1</version>
+	<version>1.4.0</version>
 	<licence>agpl</licence>
 	<author>Nextcloud</author>
 	<types>

babel.config.js

@@ -0,0 +1,10 @@
+module.exports = {
+	presets: [
+		[
+			'@babel/preset-env',
+			{
+				modules: false
+			}
+		]
+	]
+}

lib/AppInfo/Application.php

@@ -86,7 +86,6 @@ private function setupGuestManagement() {
 				'OCA\Files::loadAdditionalScripts',
 				function () {
 					\OCP\Util::addScript('guests', 'main');
-					\OCP\Util::addStyle('guests', 'app');
 				}
 			);
 		}

lib/Controller/SettingsController.php

@@ -26,7 +26,6 @@
 use OCA\Guests\Config;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\DataResponse;
-use OCP\IConfig;
 use OCP\IRequest;
 use OCP\L10N\IFactory;
 

lib/GuestManager.php

@@ -176,6 +176,7 @@ public function getGuestInfo($userId) {
 		return [
 			'shares' => array_map(function (IShare $share) {
 				return [
+					'id' => $share->getId(),
 					'shared_by' => $share->getSharedBy(),
 					'mime_type' => $share->getNodeCacheEntry()->getMimeType(),
 					'name' => $share->getNodeCacheEntry()->getName(),

lib/RestrictionManager.php

@@ -101,8 +101,6 @@ public function setupRestrictions() {
 			/** @var NavigationManager $navManager */
 			$navManager = $this->server->getNavigationManager();
 
-			\OCP\Util::addStyle('guests', 'personal');
-
 			$this->server->registerService('NavigationManager', function () use ($navManager) {
 				return new FilteredNavigationManager($this->userSession->getUser(), $navManager, $this->whitelist);
 			});