Upload button does not work

[Sanookmakmak]

Steps to reproduce

1. Open the gallery
2. Click on the + sign
3. Try to upload a picture

Expected behaviour

Picture should be uploaded

Actual behaviour

Nothing happens

More information

https://help.nextcloud.com/t/nc-11-gallery-16-0-0-no-picture-upload-possible/

This issue is already filed as bug but posted in the wrong category.

nextcloud/server#3229

Can an admin move it to here please?
Thank you.

[oparoz]

We can't move an issue across projects, so just copy/paste the OP from server to replace the OP here. Thanks!

[Sanookmakmak]

done @oparoz

[oparoz]

Drag and drop is also broken.

@rullzer Any idea what has changed in the server in 11 regarding uploads?

[JaredBoone]

When this is fixed please consider backporting to the stable11 branch.

[oparoz]

The first step is for people to post logs so that we can get a hint of what's happening.

[JaredBoone]

I have reproduced this in Windows 7 with Chrome 56.0.2924.87 and Firefox 51.0.1. I have also reproduce it in OS X Yosemite 10.10.5 with Chrome 56.0.2924.87 and Firefox 51.0.1.

Here are the steps to reproduce:

• Open Gallery app
• Click on upload "+" icon
• Click on the "Upload" menu item
• Select an image file to upload from my local file system
• Click the "Open" button
• Observe that the file selector dialog closes, but nothing else happens and no file is uploaded. In the browser web developer tools, no network requests are sent to the server, no javascript console log or error message appears.

How can I help?

[oparoz]

PLease add 'debug' => true,` to your config.php to see if it helps generate browser logs.

[JaredBoone]

I set 'debug' to true in config.php but I don't see any additional output in the browser logs.

I also modified apps/files/js/file-upload.js - I set "_trace" to true, but I see no console output from the "log" function in that file.

[JaredBoone]

Uploading this same file works fine when I use the "Files" app. Also, when using the Files app, I see multiple lines of browser console log output from file-upload.js (after setting _trace set to true).

[oparoz]

Basically, this commit broke everything:
nextcloud/server@59c5be1

So someone needs to match the changes or we need to remove the functionality.

[Sanookmakmak]

we need to remove the functionality.

Why does the files app can upload the file without any problems and the gallery app can't?

[oparoz]

Why does the files app can upload the file without any problems and the gallery app can't?

Because there isn't a shared component apps can use to make it possible to perform classic files operations such as upload, move, copy. Each app has to implement it. In order to not have to write too much code which is unrelated to Files, I re-used the base libraries, but the way it works has changed last year, so Gallery needs to get the same changes.

[Sanookmakmak]

Because there isn't a shared component apps can use to make it possible to perform classic files operations such as upload, move, copy. Each app has to implement it.

So every developer has to invent the wheel again. Wouldn't that be a nice improvement for a new Nextcloud version?
;-)

[jasonbayton]

@Sanookmakmak interestingly a comment a user Stuart on the forum keeps bringing up. Shared intents and whatnot.

It's a grand idea.

[hudriwu]

any news? does an update to 11.0.2 solve the problem?

[oparoz]

No, this will be in NC 12 and backported to 11.0.3

[oparoz]

Fix is in #238