Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Browser freezes to death after click on "start playing" if the audio-player app is not activated #10

Closed
EV21 opened this issue Apr 4, 2018 · 8 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@EV21
Copy link

EV21 commented Apr 4, 2018

Checked with Firefox - result is total death + RAM is continuous filling until it is full
Checked with Chrome - result is tab death

I think there is a need for a check if the audioplayer app is active/installed.

@EV21 EV21 changed the title Browser freezes to death after click on "start playing" when the audio-player app is not activated Browser freezes to death after click on "start playing" if the audio-player app is not activated Apr 4, 2018
@NastuzziSamy NastuzziSamy added bug Something isn't working help wanted Extra attention is needed labels Apr 4, 2018
@NastuzziSamy
Copy link
Member

Hey thx for all your feedbacks ;)

It was on my TODOs; any idea of how it is checkable ?

@EV21
Copy link
Author

EV21 commented Apr 4, 2018

I have not dealt with that yet and I have not programmed much with php or js yet.
Maybe there is help on the forums

@EV21
Copy link
Author

EV21 commented Apr 8, 2018

I think there might be a solution for this somewhere in these files.
server/lib/public/App/IAppManager.php
server/lib/private/App/AppManager.php
server/tests/lib/App/AppManagerTest.php

@GoetheG
Copy link

GoetheG commented Apr 24, 2018

Hey guys,
Hey @NastuzziSamy

Thank you for this app. It is really great! I want to add that my browser sometimes freezes too, not only with the audio player.

I wish your app become part of Nextcloud core :). This would make everything easier to use and would decrease the amount of apps.

@NastuzziSamy
Copy link
Member

Hi @GoetheG,

Thank you for your feedback, I am working on a fully new version of RightClick to allow any app to create its own right click menu.

Do you have any idea what causes that ?

I will soon push an update to repair the application bug ;)

@NastuzziSamy
Copy link
Member

@EV21 & @GoetheG , it is fixed now here 8ba422a !

The issue was that the audioplayer app changed.
I added an available application recognization.

@GoetheG
Copy link

GoetheG commented Apr 25, 2018

Hi @NastuzziSamy,

You are really great! Thank you for the very quick response! Great work. Just installed the update. Your work is a real treat for the Nextcloud community!

Yours

@NastuzziSamy
Copy link
Member

@GoetheG, all my pleasure ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants