Check path validity on Windows will validate NTFS permissions for network drives

[allexzander]

Based on #5510

Signed-off-by: Alkl58 [email protected]

[allexzander]

@Alkl58 I had to create a new PR

[codecov]

Codecov Report

Merging #6209 (e30decc) into master (dd178f0) will decrease coverage by 0.04%.
Report is 4 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head e30decc differs from pull request most recent head 9c68399. Consider uploading reports for the commit 9c68399 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6209      +/-   ##
==========================================
- Coverage   60.77%   60.74%   -0.04%     
==========================================
  Files         145      145              
  Lines       18836    18841       +5     
==========================================
- Hits        11448    11445       -3     
- Misses       7388     7396       +8     

Files	Coverage Δ
src/common/utility.h	0.00% <ø> (ø)
src/common/utility_win.cpp	45.57% <0.00%> (-1.04%)	⬇️

... and 1 file with indirect coverage changes

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6209-9c6839969cd77b8fbb5064a5913a22f6d66d0fbe-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[Alkl58]

Builds are failing because of the following reason:

[Errno 2] No such file or directory: 'meson'
Traceback (most recent call last):
  File "/Users/runner/work/desktop/desktop/macos-64-clang/craft/bin/craft.py", line 417, in <module>
    success = main(timer)
  File "/Users/runner/work/desktop/desktop/macos-64-clang/craft/bin/craft.py", line 399, in main
    if not CraftCommands.run(package, action, tempArgs):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/CraftCommands.py", line 458, in run
    if not handlePackage(info, action, directTargets=directTargets):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/CraftCommands.py", line 111, in handlePackage
    if not doExec(package, action):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/CraftCommands.py", line 60, in doExec
    ret = package.instance.runAction(action)
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/Package/PackageBase.py", line 275, in runAction
    if not getattr(self, step)():
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/BuildSystem/MesonBuildSystem.py", line 127, in configure
    if not utils.system(Arguments(["meson", "setup", extra_options, self.configureOptions(defines)])):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/utils.py", line 218, in system
    return systemWithoutShell(
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/utils.py", line 325, in systemWithoutShell
    proc = subprocess.Popen(cmd, **kw)
  File "/Users/runner/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Users/runner/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/subprocess.py", line 1837, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'meson'

Which is an issue during the dependency install stage - the worker doesn't even reach the building state.

[allexzander]

Builds are failing because of the following reason:

[Errno 2] No such file or directory: 'meson'
Traceback (most recent call last):
  File "/Users/runner/work/desktop/desktop/macos-64-clang/craft/bin/craft.py", line 417, in <module>
    success = main(timer)
  File "/Users/runner/work/desktop/desktop/macos-64-clang/craft/bin/craft.py", line 399, in main
    if not CraftCommands.run(package, action, tempArgs):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/CraftCommands.py", line 458, in run
    if not handlePackage(info, action, directTargets=directTargets):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/CraftCommands.py", line 111, in handlePackage
    if not doExec(package, action):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/CraftCommands.py", line 60, in doExec
    ret = package.instance.runAction(action)
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/Package/PackageBase.py", line 275, in runAction
    if not getattr(self, step)():
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/BuildSystem/MesonBuildSystem.py", line 127, in configure
    if not utils.system(Arguments(["meson", "setup", extra_options, self.configureOptions(defines)])):
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/utils.py", line 218, in system
    return systemWithoutShell(
  File "/Users/runner/work/desktop/desktop/craft-clone/bin/utils.py", line 325, in systemWithoutShell
    proc = subprocess.Popen(cmd, **kw)
  File "/Users/runner/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Users/runner/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/subprocess.py", line 1837, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'meson'

Which is an issue during the dependency install stage - the worker doesn't even reach the building state.

thanks, we will need to check the Craft part

[allexzander]

not releasing, as it brings issues with VFS placeholders