Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finder sidebar icon displays incorrectly #3695

Closed
SuperManifolds opened this issue Aug 20, 2021 · 16 comments · Fixed by #4367
Closed

Finder sidebar icon displays incorrectly #3695

SuperManifolds opened this issue Aug 20, 2021 · 16 comments · Fixed by #4367
Labels
bug confirmed bug approved by the team os: 🍎 macOS

Comments

@SuperManifolds
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Expected behaviour

The Nextcloud icon in the Finder sidebar should take on the system accent colour when displayed in macOS 11 and above.

Actual behaviour

The icon renders in black
finder sidebar icon

This is likely because the image asset is not configured as a "template".

Steps to reproduce

  1. Install NextCloud on macOS 11 or above
  2. Drag the NextCloud sync folder into the favourites section of the Finder sidebar

Client configuration

Client version: 20.0.12

Operating system: macOS 11.5.1

OS language: English (UK)

Installation path of client: /Applications

@akufuncture
Copy link

akufuncture commented Nov 1, 2021

It’s happening on all three of my Macs on Monterey. Didn’t notice that on Big Sur because I was always in Dark Mode and the icons used to be black. Now it’s grayish.

@snab43
Copy link

snab43 commented Dec 4, 2021

This seems to affect a few syncing apps at the moment. Is there any work around or user fixes? I know it's purely cosmetic but it's been bothering me.

@ntompson
Copy link

ntompson commented Jan 8, 2022

This happens in light mode as well (Monterey):

Screen Shot 2022-01-08 at 8 06 36 pm

@depressiveRobot
Copy link

depressiveRobot commented Feb 2, 2022

For me, the icon looks totally different respectively is wrong:
Screen Shot 2022-02-02 at 22 42 24

I tried uninstalling the app completely using AppCleaner (selecting everything) and reinstalled it (using installer for version 3.4.2).

Nextcloud 3.4.2
macOS 12.2

@fasci
Copy link

fasci commented Mar 21, 2022

The problem disappeared for me with an update to macOS 12.3.

@foss-
Copy link

foss- commented Mar 21, 2022

@fasci can you post a screenshot?
For me on macOS 12.3 the icon used in finder sidebar is still wrong:
Screenshot 2022-03-21 at 14 51 17

@fasci
Copy link

fasci commented Mar 21, 2022

@foss- Sure, that's how it looks for me with macOS 12.3 (21E230), and Nextcloud Desktop client, version 3.4.2.
Screenshot 2022-03-21 at 16 14 28

@SuperManifolds
Copy link
Author

SuperManifolds commented Mar 21, 2022

Can confirm the issue has disappeared for me as well as of 12.3

screenshot

@foss-
Copy link

foss- commented Mar 21, 2022

@foss- Sure, that's how it looks for me with macOS 12.3 (21E230), and Nextcloud Desktop client, version 3.4.2. Screenshot 2022-03-21 at 16 14 28

macOS 12.3
Nextcloud Desktop 3.4.4git (build 9585)
159275431-b5517f0e-1332-4553-b6f5-785b68a9ebe8

Is the icon still correct for you with 3.4.4? Curious why results would differ. Tried removing folder from sidebar and re-added it but the wrong AppStore icon returned for me.

@depressiveRobot
Copy link

The problem was fixed with a clean install of macOS 12.3 and Nextcloud Desktop client 3.4.2.

However, with the update to version 3.4.4 the icon is wrong again, showing the App Store icon, just as with @foss-.

@fasci
Copy link

fasci commented Mar 22, 2022

The problem was fixed with a clean install of macOS 12.3 and Nextcloud Desktop client 3.4.2.

However, with the update to version 3.4.4 the icon is wrong again, showing the App Store icon, just as with @foss-.

Oh, ok. Than I shall never update! 🙂

@foss-
Copy link

foss- commented Mar 22, 2022

3.5.0RC1 shows AppStore Icon for NextCloud folder in Finder on macOS 12.3. Should this be tagged regression since briefly (3.4.2) the correct icon was used?
Maybe macOS dependent since the icon is correct with 3.5.0RC1 on macOS 10.15.7 (19H1824).

@claucambra
Copy link
Collaborator

Hey folks, closing this issue since this has been resolved in macOS 12.3 and was an OS-level bug. Thanks for reporting!

@foss-
Copy link

foss- commented Jun 8, 2022

@claucambra can you post a screenshot of what the icon should look like now? Still seeing the App Store icon here on macOS 12.4 with NC desktop 3.5.1.

@claucambra
Copy link
Collaborator

@foss- Here's a picture:

Screenshot 2022-06-09 at 00 18 28

It might seem like a fairly tech support-y answer but have you tried uninstalling/reinstalling the client?

@foss-
Copy link

foss- commented Jun 9, 2022

Uninstalled via AppCleaner so plist and other files were removed along the app.
Reinstalled 3.5.1 and indeed icon shows as expected. 🎉

@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to ☑️ Done in 🤖 🍏 Mobile clients team Aug 18, 2022
@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Mobile clients team Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug approved by the team os: 🍎 macOS
Projects
Development

Successfully merging a pull request may close this issue.

9 participants