Fix code smells

Signed-off-by: Claudio Cambra <[email protected]>
nextcloud · Jan 10, 2022 · 0d0ba63 · 0d0ba63
1 parent 9e006d5
commit 0d0ba63
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/src/gui/internallinkwidget.cpp b/src/gui/internallinkwidget.cpp
@@ -37,7 +37,7 @@ InternalLinkWidget::InternalLinkWidget(AccountPtr account,
     _ui->setupUi(this);
 
     //Is this a file or folder?
-    QFileInfo fi(localPath);
+    const QFileInfo fi(localPath);
     _isFile = fi.isFile();
 
     const auto folder = FolderMan::instance()->folderForPath(localPath);
@@ -63,11 +63,6 @@ InternalLinkWidget::InternalLinkWidget(AccountPtr account,
     connect(_ui->copyInternalLinkButton, &QPushButton::clicked, this, &InternalLinkWidget::slotCopyInternalLink);
 }
 
-InternalLinkWidget::~InternalLinkWidget()
-{
-    delete _ui;
-}
-
 void InternalLinkWidget::setupUiOptions()
 {
     customizeStyle();
@@ -83,7 +78,7 @@ void InternalLinkWidget::slotLinkFetched(const QString &url)
 
 void InternalLinkWidget::slotCopyInternalLink(const bool clicked) const
 {
-    Q_UNUSED(clicked);
+    Q_UNUSED(clicked)
 
     QApplication::clipboard()->setText(_internalUrl);
 }

diff --git a/src/gui/internallinkwidget.h b/src/gui/internallinkwidget.h
@@ -20,17 +20,14 @@
 #include "QProgressIndicator.h"
 #include <QList>
 #include <QToolButton>
+#include <QScopedPointer>
 
 namespace OCC {
 
 namespace Ui {
     class InternalLinkWidget;
 }
 
-/**
- * @brief The ShareDialog class
- * @ingroup gui
- */
 class InternalLinkWidget : public QWidget
 {
     Q_OBJECT
@@ -39,7 +36,7 @@ class InternalLinkWidget : public QWidget
     explicit InternalLinkWidget(AccountPtr account,
         const QString &localPath,
         QWidget *parent = nullptr);
-    ~InternalLinkWidget() override;
+    ~InternalLinkWidget() = default;
 
     void toggleButton(bool show);
     void setupUiOptions();
@@ -54,7 +51,7 @@ private slots:
 private:
     void customizeStyle();
 
-    Ui::InternalLinkWidget *_ui;
+    QScopedPointer<Ui::InternalLinkWidget> _ui;
     AccountPtr _account;
     QString _localPath;
     QString _internalUrl;