-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach files to cards [$30 awarded] #109
Comments
Let's move this to 0.3 since it requires more work and due dates will be added without the attachment approach. |
Point 3 (files): is that about displaying a file (image, maybe video / sound?) inline, or about actually storing files in Deck? If the latter, isn't that redundant, seeing as storing files is the main purpose of Nextcloud? The way I use it is to store the files in Nextcloud and then link to them (via the “local link” feature in NC, e.g., |
Using the local file link sounds like a good idea except that files and the deck might have different permissions and therefore some users might not be able to work with the files. For a first implementation my plan was to just allow to attach files to cards by selecting them from the Nextcloud files using a file picker. For uploads storing in the Nextcloud filesystem might be an issue because we don't know where the files should be stored. Maybe we could expose some kind of virtual folders to the Nextcloud files app that will just contain the files uploaded directly to deck. But I need to dig more into the API Nextcloud provides for files to make this more clear. |
Yes, I actually consider that a feature and have used it in that way. E.g., you can mention something in a card while pointing to sensitive details in a file with more restrictive permissions.
The Notes app commandeers a directory ( I would suggest that whichever approach is taken, in the end the files should be stored as regular Nextcloud files. One thing to keep in mind: sooner or later Deck will have a client app written for it. In that case, the Deck API should be able to work even if using an application password with no file system access. From a security point of view, the HTTP Upload XEP may offer some inspiration, in particular the security section. Comment updated with links and some more details. |
Just some thoughts on the attachments added to cards. Files are stored in Nextcloud the usual way. |
Insightful comment above. However, since one can just link to the file in the usual Markdown way, e.g.,
is this feature really necessary or is it getting into gold-plating territory? |
@9662 that requires a lot of "work" from a user - go to Files app, find the file needed, copy the link, return to Deck app, find the card add (and know) the Markdown code needed. Additionally, user won't get information on the board that a certain item has attachment. Finally, if we want to go the Trello way, thumbnail-sized versions of attached image would show on board view of the given card - Markdown prevents this possibility. |
Yes it is really a required feature. |
👍 Yes, we should make it easy to attach a file with a file selector.
Not sure about that, but I guess that is something to discuss once we have the basic file feature. |
Perhaps, but wouldn't it be desirable for that to be improved in the Nextcloud frontend itself (e.g., nextcloud/server#6005), rather than to be worked around on a per-application basis?
Deck can scan the contents of the note for any in-cloud links (or for any links whatever) and show an appropriate indication.
Not if you use direct links as I mentioned above:
That is a separate discussion. Personally, I would concentrate on matching those guys on snappiness and performance first, then think about features, given the mismatch on hands available.
It is perfectly possible to configure the markdown processor to scan the links and produce thumbnails (server- or client-side). This would be a separate requirement than “attach files” though. Note: I am not against this feature per se, I am however rather dubious about the driver for it, which seems to boil down to “someone else has it, let's copy them!” Why not focus instead on what users' actual requirements are, and then implement them in a way that takes advantage of the application's own environment? Precisely, a big advantage of Deck over the competitor mentioned above is that it is embedded within a cloud solution. Why not take advantage of that and integrate seamlessly with its host, instead of duplicating features and functionality, with the consequent increase in code maintainability costs and cognitive load for the user? |
Any update for this feature? |
@arjoni It won't make it into 0.3. I want to do a release soon, so we are compatible with the upcoming NC13. Feel free to add a bounty if you want to support the development of this feature. https://www.bountysource.com/issues/44724860-attach-files-to-cards |
Hi Julius, are there any news on this feature? Kind regards, S. |
What if the attachment is stored in Nextcloud? Download the file and upload into Deck? |
@helmut72 That would be a different issue, feel free to open one for that. In general Nextcloud lacks of an API to allow proper sharing into apps right now. The relevant server issue is at nextcloud/server#10292 |
@juliushaertl Thanks for explanation. |
Users should be able to attach files to cards.
Edit:
The $30 bounty on this issue has been claimed at Bountysource.
The text was updated successfully, but these errors were encountered: